Skip to content

Conversation

@KeshavSoni2511
Copy link
Contributor

@KeshavSoni2511 KeshavSoni2511 commented Apr 24, 2023

Fix for issue #195

Resolved with master branch link. Sorry for the wrong commit.
@KeshavSoni2511
Copy link
Contributor Author

Hi @fgalan done with the required changes.

@fgalan
Copy link
Member

fgalan commented Apr 27, 2023

We are currently in a large re-work of the whole IOTA documentation (master issue: telefonicaid/iotagent-node-lib#1329). This PR could potentially conflict in the modifications files done by the refactor, so my suggestion is to choose some of the followings:

  1. On hold this PR until the re-work is done (i.e. issue Documentation rework iotagent-node-lib#1329 completed). Then, check that the new documentation takes into account your fixes. In positive case, this PR could be closed. In negative case, this PR would be adapted to add the missing fixes.
  2. Close this PR and reevaluate after the re-work if it is needed or not.

What do you think?

@KeshavSoni2511
Copy link
Contributor Author

Hey, @fgalan please put the PR on hold and issue.

@fgalan fgalan changed the title Updated Document for installation guide and usernamual [ON HOLD] Updated Document for installation guide and usernamual Apr 27, 2023
@fgalan
Copy link
Member

fgalan commented Apr 27, 2023

Hey, @fgalan please put the PR on hold and issue.

Done. Title has been adjusted. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants