Added a field to recorder service that can be overwritten to display another title

[TurRil]

As a plugin I want to be able to display another title in the recorder UI so that when a user sees the galicaster screen their name could be displayed correctly.

[andiempett]

I'm not sure that modifying the variable in the RecorderService class directly is the best way to do this.
i'd suggest having a method in the class that does this probably. something like:

    def set_title_standin(self, title):
        self.title_standin = title

You can test this PR with the below plugin

from galicaster.core import context


def init():
    dispatcher = context.get_dispatcher()
    dispatcher.connect('timer-short', hello_world)
    dispatcher.connect('timer-long', say_hello)


def hello_world(signal=None):
    print context.get('recorder').title_standin


def say_hello(signal=None):
    context.get('recorder').title_standin = 'Hello World!'

[andiempett]

from testing i seems this only affects manually recorded mediapackages, the title in the events panel in the recorder UI is changed only and seems to work well.

[andiempett]

hey sorry! this is almost there.
i think you forgot to call self.recorder.set_title_standin(self, title) here

[Alfro]

I think not, it looks like the set_title_standin() function is meant to be called through a plugin (and if not the behaviour should be the same as before this PR)
@TurRil can you confirm?

[Alfro]

Hi @TurRil, sorry for the huge delay here.
I'm hesitant to merge this, as I think we should not add this logic using the recorder service.

What do you think of adding the title_standin to classui.mainwindow?

[Alfro]

This should not be added to the recorder service.
See if you can add it to the classui/mainwindow instead (to keep ui logic on the ui)

[Alfro]

I think not, it looks like the set_title_standin() function is meant to be called through a plugin (and if not the behaviour should be the same as before this PR)
@TurRil can you confirm?