Fix java first program tutorial setMaximumAttempts value inconsistency#453
Open
illenko wants to merge 1 commit intotemporalio:mainfrom
Open
Fix java first program tutorial setMaximumAttempts value inconsistency#453illenko wants to merge 1 commit intotemporalio:mainfrom
illenko wants to merge 1 commit intotemporalio:mainfrom
Conversation
|
@illenko is attempting to deploy a commit to the Temporal Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Author
|
@angelazhou32 maybe you can help with review and merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Value for setMaximumAttempts in RetryOptions config in Run your first Temporal application with the Java SDK tutorial (https://learn.temporal.io/getting_started/java/first_program_in_java/).
Why?
Old value (5000) was not realistic for the scenario and conflicted with the sentence "it'll retry the failed Activity for 3 attempts". Set it to 3 to be more consistent with .NET (https://learn.temporal.io/getting_started/dotnet/first_program_in_dotnet/) and Python tutorials (https://learn.temporal.io/getting_started/python/first_program_in_python/).