Copilot/evaluate cipher selection issue#9437
Open
abryant418 wants to merge 3 commits intotemporalio:mainfrom
Open
Copilot/evaluate cipher selection issue#9437abryant418 wants to merge 3 commits intotemporalio:mainfrom
abryant418 wants to merge 3 commits intotemporalio:mainfrom
Conversation
Co-authored-by: abryant418 <106828924+abryant418@users.noreply.github.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This pull request introduces support for configuring allowed TLS cipher suites for Temporal servers and clients, enhancing security by allowing administrators to restrict which cipher suites are used for TLS 1.0–1.2 connections. The changes include updates to configuration structs, validation logic, TLS config creation, and comprehensive test coverage for the new feature.
Why?
Tell your future self why have you made these changes.
How did you test it?
Potential risks
Woudl allow users to block valid traffic with overly strict SHA configuration.