Skip to content

Copilot/evaluate cipher selection issue#9437

Open
abryant418 wants to merge 3 commits intotemporalio:mainfrom
abryant418:copilot/evaluate-cipher-selection-issue
Open

Copilot/evaluate cipher selection issue#9437
abryant418 wants to merge 3 commits intotemporalio:mainfrom
abryant418:copilot/evaluate-cipher-selection-issue

Conversation

@abryant418
Copy link

@abryant418 abryant418 commented Mar 5, 2026

What changed?

This pull request introduces support for configuring allowed TLS cipher suites for Temporal servers and clients, enhancing security by allowing administrators to restrict which cipher suites are used for TLS 1.0–1.2 connections. The changes include updates to configuration structs, validation logic, TLS config creation, and comprehensive test coverage for the new feature.

Why?

Tell your future self why have you made these changes.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

Potential risks

Woudl allow users to block valid traffic with overly strict SHA configuration.

@abryant418 abryant418 requested review from a team as code owners March 5, 2026 23:30
@CLAassistant
Copy link

CLAassistant commented Mar 5, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ abryant418
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants