Skip to content

Fix schedule edit form infinite effect loop#3172

Merged
Alex-Tideman merged 1 commit intomainfrom
schedule-form-fix
Feb 20, 2026
Merged

Fix schedule edit form infinite effect loop#3172
Alex-Tideman merged 1 commit intomainfrom
schedule-form-fix

Conversation

@Alex-Tideman
Copy link
Collaborator

Change preset from $derived to $state to prevent read-only conflict with bind:preset two-way binding. Guard the clearSchedule $effect to only run on preset changes, avoiding circular updates through $bindable prop bindings.

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Change preset from $derived to $state to prevent read-only conflict
with bind:preset two-way binding. Guard the clearSchedule $effect to
only run on preset changes, avoiding circular updates through $bindable
prop bindings.
@vercel
Copy link

vercel bot commented Feb 20, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 20, 2026 2:51am

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 20, 2026

Warnings
⚠️

📊 Strict Mode: 6 errors in 2 files (0.5% of 1117 total)

src/lib/components/schedule/schedule-form/schedules-calendar-view.svelte (1)
  • L120:10: Type 'string | null | undefined' is not assignable to type 'string | undefined'.
src/lib/components/schedule/schedule-form/form.svelte (5)
  • L122:10: Type '{ encoding: "json/plain" | "json/protobuf"; messageType: string | undefined; hour: string; minute: string; second: string; phase: string; cronString: string; daysOfWeek: string[]; daysOfMonth: number[]; ... 8 more ...; taskQueue: string; }' is missing the following properties from type '{ name: string; days: string; encoding: "json/plain" | "json/protobuf"; workflowId: string; workflowType: string; taskQueue: string; searchAttributes: { type: "Unspecified" | "Keyword" | ... 5 more ... | "Datetime"; label: string; value?: any; }[]; ... 12 more ...; messageType?: string | undefined; }': editInput, timezoneName
  • L143:32: Argument of type 'ISchedule | null' is not assignable to parameter of type 'ISchedule | undefined'.
  • L212:15: Type 'string | undefined' is not assignable to type 'string'.
  • L215:15: Type 'string | undefined' is not assignable to type 'string'.
  • L216:10: Type 'IPayloads | null | undefined' is not assignable to type 'IPayloads'.

Generated by 🚫 dangerJS against 3ae0c5a

@Alex-Tideman Alex-Tideman merged commit dfc6b45 into main Feb 20, 2026
17 checks passed
@Alex-Tideman Alex-Tideman deleted the schedule-form-fix branch February 20, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments