Add get_config and from_config methods to DenseVariational_v2#1695
Open
Frightera wants to merge 2 commits intotensorflow:mainfrom
Open
Add get_config and from_config methods to DenseVariational_v2#1695Frightera wants to merge 2 commits intotensorflow:mainfrom
Frightera wants to merge 2 commits intotensorflow:mainfrom
Conversation
Contributor
Author
|
Hi @csuter, is there any chance that you can take a look at this tiny PR? Thanks. |
Member
|
thanks for sending. please add some unit tests covering the new behavior, in the corresponding test file. would any other layers benefit from adding the same new behavior? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue #1627:
NotImplementedError: Layer DenseVariational has arguments in __init__ and therefore must override get_configSome unit tests are failing due to an internal issue in TF-Nightly as of 17/02/2023. Please find the gist here to see the fix.
Thanks!