Use push job#244
Merged
Merged
Conversation
moshe-kabala
force-pushed
the
use_push_job
branch
2 times, most recently
from
f41837c to
b262ad1
Compare
leap push for a new model now triggers the single push job (POST /versions/push) that runs code parse and model import back to back, instead of calling pushCodeSnapshot then importModel as two separate jobs/round-trips. - code.PushCodeAndModel uploads the code bundle and calls the new Push API. - model.WaitForPushJob waits on the single job and reports import/validation errors on failure. - runPushFlow routes a new model through the combined push; overwriting a version that already has a model keeps the code-parse + re-validate flow, since the push job always imports a model. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
A failed push reused the import-model error report ("Import Model Error
Report"), which is confusing for a push. Add ToPushReportPages (same content,
push-titled) and use it in WaitForPushJob; the import/override flows keep the
import-model report.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Overwriting a version that already has a model now goes through the new override-push API (POST /versions/pushOverride) instead of the old pushCodeSnapshot + OverrideModel jobs: code.PushOverride uploads the code and calls pushOverride (no model upload, no name — both come from the overwritten version), then WaitForPushJob waits on the single job. New-model / new-version pushes still go through runCombinedPush. Removes the now-dead pushCodeAndWaitForParsing / overrideExistingModel / tagCodeResp. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
WaitForPushJob reused waitForImportModelJob, which printed "Waiting for import model result..." during a push/override-push. Parameterize the label: the push path prints "push", the standalone import/override paths keep "import model". Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The node-server dropped the standalone importModel/overwriteModel/ pushCodeSnapshot endpoints (folded into the combined push job), so the regenerated tensorleapapi SDK no longer exposes them. Remove the now-dead wrappers that called them — model.ImportModel, model.OverrideModel, code.PushCodeSnapshot and code.PushCode — none of which are reached by the push flow (PushCodeAndModel / PushOverride). Builds clean against the new SDK. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
moshe-kabala
force-pushed
the
use_push_job
branch
from
b262ad1 to
7fb1832
Compare
The regenerated tensorleapapi SDK renamed DatasetTestResultPayload -> CodeTestResultPayload (engine dataset->code rename). Update the one remaining app-code reference in the push error report. Builds clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.