feat: Switch to landscape when fullscreen is activated#949
feat: Switch to landscape when fullscreen is activated#949Gowreesh-A-M wants to merge 2 commits intomasterfrom
Conversation
Gowreesh-A-M
commented
Sep 30, 2025
- Added a setting to change orientation to landscape only when fullscreen mode is entered in WebView.
- Updated activities to respect this setting.
- WebChromeClient applies the orientation change on fullscreen.
Summary of ChangesHello @Gowreesh-A-M, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a new feature that allows for configurable screen orientation behavior when a WebView enters fullscreen mode. Specifically, it introduces a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new feature to switch to landscape orientation when fullscreen mode is activated in WebView. The changes involve adding a setting to control this behavior and updating activities and the WebChromeClient to respect the setting. The code changes look good, and I have added a review comment to address a potential issue.