Skip to content

feat: Add resolution fallback support to download API#131

Merged
Balamurugan-Testpress merged 5 commits intomainfrom
download-api-resolution-fallback
Mar 5, 2026
Merged

feat: Add resolution fallback support to download API#131
Balamurugan-Testpress merged 5 commits intomainfrom
download-api-resolution-fallback

Conversation

@Balamurugan-Testpress
Copy link
Contributor

  • Enable optional fallback when the requested resolution is unavailable
  • Select the closest available resolution when fallback is enabled
  • Prefer the lower resolution if multiple options are equally close

- Enable optional fallback when the requested resolution is unavailable
- Select the closest available resolution when fallback is enabled
- Prefer the lower resolution if multiple options are equally close
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the download API by introducing a robust resolution fallback mechanism. It allows clients to specify whether the system should attempt to find an alternative resolution if the exact requested one is unavailable, ensuring a more resilient download experience. The new logic intelligently selects the closest available resolution, with a preference for lower resolutions in case of a tie, improving flexibility and user experience for content downloads.

Highlights

  • Resolution Fallback: Introduced an optional 'allowResolutionFallback' parameter to the download API, enabling the system to find an alternative resolution if the requested one is not available.
  • Closest Resolution Selection: Implemented logic to automatically select the closest available video resolution when fallback is enabled and the exact requested resolution is not found.
  • Tie-breaking Preference: When multiple resolutions are equally close to the requested one, the system now prefers the lower resolution to optimize for download size or compatibility.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Source/Database/TPStreamsDownloadManager.swift
    • Added 'allowResolutionFallback' parameter to the 'startDownload' method.
    • Introduced 'selectQuality' and 'parseResolution' helper methods to handle resolution selection and parsing.
    • Modified the 'startDownload' method to utilize the new 'selectQuality' function for determining the appropriate video quality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable feature for resolution fallback when downloading videos. A security audit found no significant vulnerabilities (Medium, High, or Critical) related to the new resolution fallback logic, data flow from untrusted inputs, or potential Swift pitfalls. The implementation is well-structured, and I've provided suggestions in TPStreamsDownloadManager.swift to improve the efficiency and robustness of the resolution selection logic, specifically regarding redundant parsing and handling complex resolution string formats.

@Balamurugan-Testpress Balamurugan-Testpress merged commit 897a1d5 into main Mar 5, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants