Skip to content

feat: Improve video quality labels in player UI#133

Merged
Balamurugan-Testpress merged 3 commits intomainfrom
enhancement-ios-video-quality-selection-ui
Mar 13, 2026
Merged

feat: Improve video quality labels in player UI#133
Balamurugan-Testpress merged 3 commits intomainfrom
enhancement-ios-video-quality-selection-ui

Conversation

@Balamurugan-Testpress
Copy link
Contributor

  • Video quality options showed raw resolution values, which were unclear when adaptive streaming was used.
  • This happened because the UI displayed resolutions without indicating the maximum possible quality.
  • The UI now shows labels as "Up to {resolution}" to clearly represent the maximum playback quality.

- Video quality options previously displayed raw resolution values, which were not clear for users when adaptive streaming was used.
- This happened because the UI directly showed available resolutions without indicating the maximum quality the stream could reach.
- The UI now displays labels in the format "Up to {resolution}", making it clearer that the selected option represents the maximum possible playback quality.
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by making video quality selections more intuitive and informative. By replacing raw resolution numbers with descriptive labels like "Up to {resolution}", the UI now clearly communicates the maximum available playback quality, particularly benefiting users in adaptive streaming scenarios.

Highlights

  • Improved Video Quality Labels: The video quality options in the player UI now display more descriptive labels, such as "Up to {resolution}", instead of just raw resolution values. This addresses the previous ambiguity, especially when adaptive streaming was used.
  • New Utility Function: A new static utility function, getDisplayLabel, was added to VideoQualityUtils to consistently generate these improved display labels for video quality options.
  • UI Integration: The updated display labels have been integrated into both the SwiftUI (PlayerSettingsButton) and UIKit (PlayerControlsUIView) player interfaces to ensure a consistent user experience across different UI implementations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • Source/Utils/VideoQualityUtils.swift
    • Added a new static function getDisplayLabel to format video quality resolutions into user-friendly strings.
  • Source/Views/SwiftUI/PlayerSettingsButton.swift
    • Updated the videoQualityButton to use the new getDisplayLabel for the current video quality display.
    • Modified videoQualityOptions to apply getDisplayLabel to each available video quality option.
  • Source/Views/UIKit/PlayerControlsUIView.swift
    • Changed the createActionForVideoQuality function to use getDisplayLabel for the UIAlertAction title.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the video quality labels by showing 'Up to {resolution}' for adaptive streaming, which is a good clarification for users. The implementation is straightforward, with a new utility function in VideoQualityUtils and its application in both SwiftUI and UIKit views. My review includes a suggestion for VideoQualityUtils.swift to improve code style and address internationalization for user-facing strings. Overall, the changes are positive and achieve the intended goal.

@Balamurugan-Testpress Balamurugan-Testpress merged commit 292a75e into main Mar 13, 2026
2 of 3 checks passed
Balamurugan-Testpress added a commit that referenced this pull request Mar 17, 2026
- Remove adaptive streaming description from download quality sheets
- Description added in PR #133 does not apply to download quality selection
- Updated in both UIKit and SwiftUI implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants