fix: Prevent ExoPlayer surface timeout during view lifecycle changes

[syed-tp]

• ExoPlayer was timing out when attempting to detach from the rendering surface during view destruction. This occurred because the player remained connected to the surface while Android was destroying it, creating a race condition.
• Now disconnect the player from the surface proactively during view detachment, and reconnect it when the view is re-attached to support navigation scenarios.

[gemini-code-assist]

Summary of Changes

Hello @syed-tp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical issue where the ExoPlayer would experience timeouts during Android view lifecycle changes, specifically when a view containing the player was being destroyed. The solution involves implementing explicit handling for player attachment and detachment from its rendering surface. By proactively disconnecting the player when the view is detached and reconnecting it upon re-attachment, the race condition that led to timeouts is eliminated, ensuring robust player behavior across various view navigation scenarios.

Highlights

• ExoPlayer Timeout Fix: Addresses an issue where ExoPlayer would time out when detaching from its rendering surface during view destruction, caused by a race condition.
• Proactive Player Detachment: The player is now explicitly disconnected from its surface in onDetachedFromWindow() to prevent timeouts when the view is being destroyed.
• Player Reconnection on View Attachment: The player is reconnected to its surface in onAttachedToWindow() to support seamless navigation scenarios where the view might be re-attached.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request addresses a critical issue where the ExoPlayer surface would time out during view destruction due to a race condition. The changes proactively disconnect the player from the rendering surface during view detachment and reconnect it when the view is re-attached. This is a good approach to handle the Android view lifecycle and prevent player timeouts.