Skip to content

fix: Add consumer proguard rules to fix release build crash#49

Merged
syed-tp merged 2 commits intomainfrom
fix/download_crash
Jan 31, 2026
Merged

fix: Add consumer proguard rules to fix release build crash#49
syed-tp merged 2 commits intomainfrom
fix/download_crash

Conversation

@syed-tp
Copy link
Contributor

@syed-tp syed-tp commented Jan 30, 2026

  • Previously, a client faced crash issues on release builds caused by aggressive R8 optimization.
  • Add consumer-rules.pro to preserve DownloadHelper and Callback, preventing the AbstractMethodError during downloads.
  • Update tpstreamsAndroidPlayerVersion to 1.1.8.

@gemini-code-assist
Copy link

Summary of Changes

Hello @syed-tp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where release builds were crashing due to aggressive R8 optimization. By introducing specific ProGuard rules, it ensures that essential components for download functionality are retained, thereby stabilizing the application in production environments. Additionally, it updates a core dependency to its latest patch version.

Highlights

  • R8 Optimization Fix: Introduced consumer-rules.pro to prevent aggressive R8 optimization from stripping necessary classes, which previously caused AbstractMethodError in release builds.
  • Class Preservation: Explicitly preserves androidx.media3.exoplayer.offline.DownloadHelper and its Callback interface to ensure their methods are not incorrectly stripped or renamed during the build process.
  • Dependency Update: Updated the tpstreamsAndroidPlayerVersion from 1.1.7 to 1.1.8 in gradle.properties.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@socket-security
Copy link

socket-security bot commented Jan 30, 2026

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a crash in release builds by adding consumer Proguard rules and updating the tpstreamsAndroidPlayerVersion. The changes look correct and should resolve the issue. I have provided a couple of suggestions to improve the Proguard rule specificity and adhere to file formatting best practices.

@syed-tp syed-tp merged commit ed8c957 into main Jan 31, 2026
7 checks passed
@syed-tp syed-tp deleted the fix/download_crash branch January 31, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant