docs: Add license duration and persistence configurations to DRM API#92
docs: Add license duration and persistence configurations to DRM API#92PReshma-tp wants to merge 5 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the DRM API documentation to accurately reflect the current capabilities for managing license duration and persistence for both Widevine and FairPlay. It introduces new parameters that allow for explicit control over these aspects, ensuring the documentation provides clear and up-to-date guidance for developers integrating with the DRM API. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the DRM API documentation to include new configuration options for license duration and persistence (license_duration_seconds, lease_duration_seconds, is_persistent) and removes the outdated license_duration field. The changes are mostly correct and improve the documentation's accuracy. I've left a couple of comments regarding markdown table formatting and a remaining reference to the deprecated license_duration field that should be removed to ensure consistency.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
3fa1d02 to
acce9ce
Compare
This PR Updates the DRM License documentation to include the supported
license_duration_seconds, lease_duration_seconds, and is_persistent
fields in the request body and also removes the false license_duration field information.
This change aligns the documentation with the current DRM API behavior
and clarifies how duration and offline playback are configured for both
Widevine and FairPlay integrations.