Merged
Conversation
The common style is "char*", not "char *".
remove the redundant const keyword.
When the header doesn't need the include but the implementation does, the include should be in the implementation file. Unneeded includes in headers slow down compilation time needlessly for everyone including the header.
jjuhl
force-pushed
the
minor-cleanups
branch
2 times, most recently
from
9f5535e to
c60f838
Compare
Owner
|
I'm a bit worried about the includes being removed from src/Filesystem.cpp, even though CI seems happy about it. |
Remove some #include's from files that don't directly use the types declared in those includes. Unneeded includes just slow down compilation and also leads to users accidentally depending on transitive includes.
jjuhl
force-pushed
the
minor-cleanups
branch
from
c60f838 to
93bc080
Compare
Contributor
Author
|
You make some good points. I've removed that bit of the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Texus
Yet another batch of tiny cleanups for you :)