Fix Issues #196 and #197 #198
Open
+1,239
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trsxvz
requested changes
Jan 19, 2026
Collaborator
trsxvz
left a comment
trsxvz
left a comment
There was a problem hiding this comment.
3 typos + 1 forgotten definition
| std::span<real>); | ||
| /*! | ||
| * \return the data associated with an integration point | ||
| * \param[in] o: offset associated wNith the integration point |
| }; | ||
|
|
||
| /*! | ||
| * \brief a srided coalescence view which acts as a tensorial function |
| @@ -0,0 +1,111 @@ | |||
| /*! | |||
| * \file MGIS/Function/Tensors/CoalescedMemoryAccessCompositeTensorsView.ixx | |||
Collaborator
There was a problem hiding this comment.
bad \file name : forgot to add "Strided" at its beginning
| const size_type) const | ||
| requires(LinearQuadratureSpaceConcept<Space>); | ||
| //! \return the underlying quadrature space | ||
| [[nodiscard]] constexpr const Space& getSpace() const noexcept; |
Collaborator
There was a problem hiding this comment.
declared but never defined. build passes because it is not tested yet, but implementing a test for it makes the build crash with error :
91 | [[nodiscard]] constexpr const Space& getSpace() const noexcept;
| ^~~~~~~~
[100%] Linking CXX executable StridedCoalescedMemoryAccessFunctionViewTest
/usr/bin/ld : CMakeFiles/StridedCoalescedMemoryAccessFunctionViewTest.dir/StridedCoalescedMemoryAccessFunctionViewTest.cxx.o : dans la fonction « StridedCoalescedMemoryAccessFunctionViewBaseTest::test2() » :
StridedCoalescedMemoryAccessFunctionViewTest.cxx:(.text._ZN48StridedCoalescedMemoryAccessFunctionViewBaseTest5test2Ev[_ZN48StridedCoalescedMemoryAccessFunctionViewBaseTest5test2Ev]+0x91) : référence indéfinie vers « mgis::function::StridedCoalescedMemoryAccessFunctionViewBase<mgis::function::BasicLinearSpace, 2ul,
true>::getSpace() const » ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.