Fix NotFound errors logged at ERROR when wrapped in multierror#341
Open
sean- wants to merge 1 commit intothought-machine:masterfrom
Open
Fix NotFound errors logged at ERROR when wrapped in multierror#341sean- wants to merge 1 commit intothought-machine:masterfrom
sean- wants to merge 1 commit intothought-machine:masterfrom
Conversation
The gRPC logging interceptors check status.Code(err) to decide whether to log at ERROR or DEBUG. When elan's GetTree handler encounters a NotFound from a child directory lookup, the error is collected via multierror.Group, which wraps it in a *multierror.Error. This loses the gRPC status code (status.Code() returns Unknown) so the interceptor logs at ERROR instead of DEBUG. Add hasGRPCCode() which uses errors.As to unwrap multierrors (and any other error wrapping) to find the underlying gRPC status code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gRPC logging interceptors check
status.Code(err)to decide whether to log atERRORorDEBUG. Whenelan'sGetTreehandler encounters aNotFoundfrom a child directory lookup, the error is collected viamultierror.Group, which wraps it in a*multierror.Error. This loses the gRPC status code (status.Code()returnsUnknown) so the interceptor logs atERRORinstead ofDEBUG.Add
hasGRPCCode()which useserrors.Asto unwrapmultierrors(and any other error wrapping) to find the underlying gRPC status code.