Match supported Ruby versions with shoulda-matchers#73
Match supported Ruby versions with shoulda-matchers#73TastyPi wants to merge 1 commit intothoughtbot:mainfrom
shoulda-matchers#73Conversation
|
Hi, @TastyPi, thank you for your PR! Sorry for taking so long to respond. To be honest, I'm having a hard time accepting that the CI got green with no changes on the Appraisals file. Rails 4.2 not failing with Ruby 3.2? I wonder if the tests have even started. I think it would be better to start using Github Actions keeping the same ruby version that we have in the project at the moment and in others PRs we could start adding or dropping until we make identical to the file in the shoulda-matchsers project. What do you think? Would you like to make one of these contributions? |
|
Makes sense to me. Are you also asking if I would implement GitHub Actions or will you take that on? |
|
Sorry, I expressed myself badly. I was asking if you were interested in converting this contribution of yours to another one, which could be adding github actions to this project. If you don't want to do that, that's fine. I'll work on that ASAP. |
I want to make sure the tests I'll be writing for #71 pass on appropriate Ruby versions.
I got the list from here https://github.com/thoughtbot/shoulda-matchers/blob/8fc832d52c36ac24d2c2d283c8d3665106f0e90f/.github/workflows/ci.yml#L29