Carve out the mm buffer region from the bulk system memory hob #11707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
leiflindholm and
samimujawar
Current MemoryPeim has excessive amount of PCD get notations. This makes the code less readable and introduced long if statements. This change reads most of the PCD get calls into local variables and reference the variables instead. Signed-off-by: Kun Qin <[email protected]>
… mem The MM communication buffer memory is being added in MM communication DXE driver through gDS calls. This means that the region should not be reported as available through resource descriptor hob. This change will carve out the MM communication buffer from the system memory hob to prevent gDS failure from MM communication DXE driver. Signed-off-by: Kun Qin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MM communication buffer memory is being added in MM communication DXE driver through gDS calls:
edk2/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c
Line 758 in 05b677c
This means that the region should not be reported as available through resource descriptor hob.
This change started with moving all PCD get calls to local variables and then carve out the MM communication buffer from the system memory.
How This Was Tested
This was tested on QEMU SBSA platform and booted to UEFI shell.
Integration Instructions
N/A