Skip to content

Conversation

@FuntimeMS
Copy link

@FuntimeMS FuntimeMS commented Nov 12, 2025

Description

ToolSetup.bat had a bug where the check for %EDK_TOOLS_BIN% was happening inside the same code block where it was assigned, so the check was failing.
I moved the check outside of the code block (if statement) where it is assigned (in 2 locations) and now it works as expected.
fixes #11744

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

I verified that the error is now reported correctly, with the missing path being displayed on the screen.

Integration Instructions

N/A

@FuntimeMS FuntimeMS changed the title Fix check and error message by moving the use of the variable outside… BaseTools: Fix check and error message by moving the use of the variable Nov 12, 2025
@gapalomi
Copy link
Contributor

CI its failing with this errors. Please correct commit message format

The commit message format is not valid:
 * Subject line not in "package,package: description" format!
 * Missing Signed-off-by! (Note: this must be added by the code contributor!)
 * First line of commit message (subject line) is too long (141 > 75).
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format

@FuntimeMS
Copy link
Author

Okay, I have added a new commit with the updated description.

@FuntimeMS
Copy link
Author

Apparently, I didn't do something right. Is it still complaining about the original commit message?
Was I supposed to modify the existing commit message instead of creating a new commit for the updated message?

@FuntimeMS
Copy link
Author

Okay, I found the error messages, modified the commit message and repushed it.
That fixed the latest commit, but I'm still getting the error for the original commit, I guess I'll see if I can re-write history and fix the original commit.

Fix check for EDK_TOOLS_BIN and corresponding error message in
ToolSetup.bat by moving the use of the variable outside of the
code block (if statement) where it is assigned (in 2 locations).

Signed-off-by: Mike Schlueter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: toolsetup.bat is trying to use delayed expansion incorrectly.

2 participants