CI: Use Fedora 43 for Linux jobs #11758
Open
+7
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 enforces stricter type checking for function pointers. When passing SPDM transport layer callbacks to libspdm_register_transport_layer_func, the function pointer types are incompatible due to differences in boolean parameter types. The EDK2 uses BOOLEAN (UINT8) while libspdm uses C99 bool (_Bool). Although these types have the same size and representation, GCC 15 treats them as incompatible. Add explicit casts to libspdm_transport_encode_message_func and libspdm_transport_decode_message_func at the call site to resolve the type mismatch. This is safe as the types have identical binary representation and the functions are only called through these pointers by libspdm. Signed-off-by: Oliver Steffen <[email protected]> (cherry picked from commit aca8f99)
GCC 15 enforces stricter type checking for function pointers. When passing EFI_PERIODIC_CALLBACK and EFI_EXCEPTION_CALLBACK to ManageIdtEntryTable, explicit casts to CALLBACK_FUNC are required to avoid incompatible pointer type errors. Add explicit casts at the call sites in RegisterPeriodicCallback and RegisterExceptionCallback functions. Signed-off-by: Oliver Steffen <[email protected]> (cherry picked from commit ff28da4)
osteffenrh
force-pushed
the
ci-fedora43
branch
2 times, most recently
from
bdf4533 to
55a0c40
Compare
The termio.h of glibc has been deprecated for decades and was finally removed in glibc 2.42. EmulatorPkg still pulls it in for no reason (the "new" termios.h is being included already). Remove the include of termio.h. Signed-off-by: Oliver Steffen <[email protected]>
osteffenrh
force-pushed
the
ci-fedora43
branch
from
55a0c40 to
b12ed47
Compare
tianocore-assign-reviewers
bot
requested review from
Javagedes,
ajfish,
jyao1,
lgao4,
makubacki,
mdkinney,
os-d and
spbrogan
Member
|
Can you please update the devcontainer file to use the Fedora 43 image? https://github.com/tianocore/edk2/blob/master/.devcontainer/devcontainer.json Also, is .github/workflows/BuildPlatform.yml intentionally being kept on the Fedora 40 image? |
The Fedora 41, which is currently in use for the azurepipelines CI, will be EOL soon. With the fixes for the C23 standard we can use GCC 15 and switch over to the latest Fedora image to run the Linux based CI jobs. Signed-off-by: Oliver Steffen <[email protected]>
Fedora 40, which is currently in use for the GitHub workflows, is EOL. With the fixes for the C23 standard we can use GCC 15 and switch over to the latest Fedora image. Signed-off-by: Oliver Steffen <[email protected]>
Fedora 40, which is currently in use as the devcontainer image, is EOL. With the fixes for the C23 standard we can use GCC 15 and switch over to the latest Fedora image. Signed-off-by: Oliver Steffen <[email protected]>
osteffenrh
force-pushed
the
ci-fedora43
branch
from
b12ed47 to
e2ba50f
Compare
Contributor
Author
|
Missed those. Switched them all to Fedora 43 now. |
makubacki
approved these changes
Nov 17, 2025
cfernald
approved these changes
Nov 17, 2025
Javagedes
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new Fedora 43 image in the CI to run Linux based jobs.
This PR includes the fixes for C23/gcc 15 from #11720, which should be merged first.