Skip to content

Conversation

@cosmolai
Copy link
Contributor

@cosmolai cosmolai commented Nov 17, 2025

… valid

The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid.

This change returns failure if dsc path is not valid.

Description

The HostUnitTestCompilerPlugin currently skips the package if the dsc path described in .ci.yaml is not valid.
This change returns failure if dsc path is not valid.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Verified it returns failure if dsc path is not valid in ci.yaml.

Integration Instructions

N/A

@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 950b3c1 to 24c3591 Compare November 17, 2025 04:27
@cosmolai cosmolai marked this pull request as ready for review November 17, 2025 05:57
@cosmolai
Copy link
Contributor Author

@mdkinney please help to review this. thanks.

@Javagedes
Copy link
Contributor

@cosmolai Please update the PR description, putting the main comments under the ## Description section, and filling out the rest of the sections.

Thanks,
Joey

… valid

The HostUnitTestCompilerPlugin currently skips the package if the dsc path
described in .ci.yaml is not valid.

This change returns failure if dsc path is not valid.

Signed-off-by: Cosmo Lai <[email protected]>
@cosmolai cosmolai force-pushed the return_error_if_dsc_not_valid branch from 24c3591 to 772e74a Compare November 18, 2025 04:00
@tianocore-pr-automation
Copy link

Pull Request Formatting Issues

⚠️ Remove the following template lines from your PR description:
<_Include a description of the change and why this change was made._>
<_For each item, place an "x" in between [and]if true. Example:[x] (you can also check items in GitHub UI)_>
<_Create the PR as a Draft PR if it is only created to run CI checks._>
<_Delete lines in \<\> tags before creating the PR._>
<_Describe the test(s) that were run to verify the changes._>
<_Describe how these changes should be integrated. Use N/A if nothing is required._>

Address these issues and the validation will automatically re-run when you update your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants