Skip to content

introduce debug log bit for paging #11840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kraxel wants to merge 4 commits into
base: master
Choose a base branch
from
+16 −15
Open

introduce debug log bit for paging #11840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
37461e7
MdePkg/DebugLib: add DEBUG_PAGING
kraxel Oct 2, 2025
3892103
OvmfPkg/BaseMemEncryptSevLib: DEBUG_VERBOSE -> DEBUG_PAGING
kraxel Oct 2, 2025
f719985
UefiCpuPkg/CpuDxe: DEBUG_VERBOSE -> DEBUG_PAGING
kraxel Dec 3, 2025
53213de
UefiCpuPkg/ArmMmuLib: DEBUG_VERBOSE -> DEBUG_PAGING
kraxel Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions MdePkg/Include/Library/DebugLib.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#define DEBUG_MANAGEABILITY 0x00800000 // Detailed debug and payload manageability messages
// related to modules such as Redfish, IPMI, MCTP etc.
#define DEBUG_SECURITY 0x01000000 // Security and security HW related messages, such as TPM
#define DEBUG_PAGING 0x02000000 // Page table updates (memory encryption, page attributes, ...)
#define DEBUG_ERROR 0x80000000 // Error

//
Expand Down
12 changes: 6 additions & 6 deletions OvmfPkg/Library/BaseMemEncryptSevLib/X64/PeiDxeVirtualMemory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ AllocatePageTableMemory (
mPageTablePool->FreePages -= Pages;

DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: Buffer=0x%Lx Pages=%ld\n",
gEfiCallerBaseName,
__func__,
Expand Down Expand Up @@ -572,7 +572,7 @@ InternalMemEncryptSevCreateIdentityMap1G (
PageMapLevel4Entry = NULL;

DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: Cr3Base=0x%Lx Physical=0x%Lx Length=0x%Lx\n",
gEfiCallerBaseName,
__func__,
Expand Down Expand Up @@ -736,7 +736,7 @@ SetMemoryEncDec (
PageMapLevel4Entry = NULL;

DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: Cr3Base=0x%Lx Physical=0x%Lx Length=0x%Lx Mode=%a CacheFlush=%u Mmio=%u\n",
gEfiCallerBaseName,
__func__,
Expand Down Expand Up @@ -859,7 +859,7 @@ SetMemoryEncDec (
if (((PhysicalAddress & (BIT30 - 1)) == 0) && (Length >= BIT30)) {
SetOrClearCBit (&PageDirectory1GEntry->Uint64, Mode);
DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: updated 1GB entry for Physical=0x%Lx\n",
gEfiCallerBaseName,
__func__,
Expand All @@ -872,7 +872,7 @@ SetMemoryEncDec (
// We must split the page
//
DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: splitting 1GB page for Physical=0x%Lx\n",
gEfiCallerBaseName,
__func__,
Expand Down Expand Up @@ -927,7 +927,7 @@ SetMemoryEncDec (
// We must split up this page into 4K pages
//
DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a:%a: splitting 2MB page for Physical=0x%Lx\n",
gEfiCallerBaseName,
__func__,
Expand Down
16 changes: 8 additions & 8 deletions UefiCpuPkg/CpuDxe/CpuPageTable.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,8 +495,8 @@ ConvertPageEntryAttribute (
*PageEntry = NewPageEntry;
if (CurrentPageEntry != NewPageEntry) {
*IsModified = TRUE;
DEBUG ((DEBUG_VERBOSE, "ConvertPageEntryAttribute 0x%lx", CurrentPageEntry));
DEBUG ((DEBUG_VERBOSE, "->0x%lx\n", NewPageEntry));
DEBUG ((DEBUG_PAGING, "ConvertPageEntryAttribute 0x%lx", CurrentPageEntry));
DEBUG ((DEBUG_PAGING, "->0x%lx\n", NewPageEntry));
} else {
*IsModified = FALSE;
}
Expand Down Expand Up @@ -575,7 +575,7 @@ SplitPage (
ASSERT (SplitAttribute == Page4K);
if (SplitAttribute == Page4K) {
NewPageEntry = AllocatePagesFunc (1);
DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry));
DEBUG ((DEBUG_PAGING, "Split - 0x%x\n", NewPageEntry));
if (NewPageEntry == NULL) {
return RETURN_OUT_OF_RESOURCES;
}
Expand All @@ -598,7 +598,7 @@ SplitPage (
ASSERT (SplitAttribute == Page2M || SplitAttribute == Page4K);
if (((SplitAttribute == Page2M) || (SplitAttribute == Page4K))) {
NewPageEntry = AllocatePagesFunc (1);
DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry));
DEBUG ((DEBUG_PAGING, "Split - 0x%x\n", NewPageEntry));
if (NewPageEntry == NULL) {
return RETURN_OUT_OF_RESOURCES;
}
Expand Down Expand Up @@ -1085,7 +1085,7 @@ RefreshGcdMemoryAttributesFromPaging (
);
ASSERT_EFI_ERROR (Status);
DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"Updated memory space attribute: [%lu] %016lx - %016lx (%016lx -> %016lx)\r\n",
(UINT64)Index,
BaseAddress,
Expand Down Expand Up @@ -1487,7 +1487,7 @@ EfiSetMemoryAttributes (
BOOLEAN IsModified;
BOOLEAN IsSplitted;

DEBUG ((DEBUG_VERBOSE, "%a: 0x%lx - 0x%lx (0x%lx)\n", __func__, BaseAddress, Length, Attributes));
DEBUG ((DEBUG_PAGING, "%a: 0x%lx - 0x%lx (0x%lx)\n", __func__, BaseAddress, Length, Attributes));

if (Attributes == 0) {
DEBUG ((DEBUG_ERROR, "%a: Error - Attributes == 0\n", __func__));
Expand Down Expand Up @@ -1563,7 +1563,7 @@ EfiClearMemoryAttributes (
BOOLEAN IsModified;
BOOLEAN IsSplitted;

DEBUG ((DEBUG_VERBOSE, "%a: 0x%lx - 0x%lx (0x%lx)\n", __func__, BaseAddress, Length, Attributes));
DEBUG ((DEBUG_PAGING, "%a: 0x%lx - 0x%lx (0x%lx)\n", __func__, BaseAddress, Length, Attributes));

if (Attributes == 0) {
DEBUG ((DEBUG_ERROR, "%a: Error - Attributes == 0\n", __func__));
Expand Down Expand Up @@ -1708,7 +1708,7 @@ EfiGetMemoryAttributes (
MemAttr = *Attributes;
} while (Size > 0);

DEBUG ((DEBUG_VERBOSE, "%a: Attributes is 0x%lx\n", __func__, *Attributes));
DEBUG ((DEBUG_PAGING, "%a: Attributes is 0x%lx\n", __func__, *Attributes));

return EFI_SUCCESS;
}
Expand Down
2 changes: 1 addition & 1 deletion UefiCpuPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ UpdateRegionMappingRecursive (
BlockMask = MAX_UINT64 >> BlockShift;

DEBUG ((
DEBUG_VERBOSE,
DEBUG_PAGING,
"%a(%d): %llx - %llx set %lx clr %lx\n",
__func__,
Level,
Expand Down
Loading