Skip to content

Conversation

@designcode
Copy link
Collaborator

@designcode designcode commented Dec 2, 2025

Note

Simplifies release linting by adding a workspace-wide publint script and using it in the release workflow.

  • CI/Release Workflow (.github/workflows/release.yaml):
    • Replace per-workspace publint commands with a single npm run publint.
  • Root package.json:
    • Add publint script that runs publint across workspaces.

Written by Cursor Bugbot for commit 7ba5bb9. This will update automatically on new commits. Configure here.

@designcode designcode merged commit 71afbab into main Dec 2, 2025
2 checks passed
@designcode designcode deleted the fix/release-steps branch December 2, 2025 14:50
npm run publint --workspace=@tigrisdata/storage
npm run publint --workspace=@tigrisdata/keyv-tigris
npm run publint --workspace=@tigrisdata/react
npm run publint
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: React package silently skipped due to missing publint script

The refactored publint script uses --workspaces --if-present, but @tigrisdata/react doesn't have a publint script defined in its package.json. The original workflow explicitly ran publint on all three packages including react. With this change, the react package will be silently skipped during linting, meaning potential publishing issues with @tigrisdata/react won't be caught. Either the react package needs a publint script added, or this silent skipping is unintentional.

Additional Locations (1)

Fix in Cursor Fix in Web

@greptile-apps
Copy link

greptile-apps bot commented Dec 2, 2025

Greptile Overview

Greptile Summary

Refactored the publint execution in the release workflow by centralizing it into a single script command. The change replaces three individual workspace-specific publint commands with a single npm run publint that leverages the --workspaces --if-present flags to run publint across all workspaces that have the script defined.

  • Simplified workflow maintenance by reducing duplication in .github/workflows/release.yaml:40-41
  • Added centralized publint script in root package.json:16
  • Correctly uses --if-present flag to skip workspaces without publint script (like @tigrisdata/react)

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are a straightforward refactoring that reduces duplication without altering functionality. The --if-present flag ensures compatibility with workspaces that don't have publint scripts, and the behavior is equivalent to the previous implementation
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/release.yaml 5/5 Simplified publint execution to use centralized script, reducing duplication
package.json 5/5 Added centralized publint script that runs across all workspaces with --if-present flag

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🎉 This PR is included in version 1.0.7 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🎉 This PR is included in version 1.1.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

🎉 This PR is included in version 2.10.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

🎉 This PR is included in version 1.0.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants