-
Notifications
You must be signed in to change notification settings - Fork 1
fix(shared): release steps #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| npm run publint --workspace=@tigrisdata/storage | ||
| npm run publint --workspace=@tigrisdata/keyv-tigris | ||
| npm run publint --workspace=@tigrisdata/react | ||
| npm run publint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: React package silently skipped due to missing publint script
The refactored publint script uses --workspaces --if-present, but @tigrisdata/react doesn't have a publint script defined in its package.json. The original workflow explicitly ran publint on all three packages including react. With this change, the react package will be silently skipped during linting, meaning potential publishing issues with @tigrisdata/react won't be caught. Either the react package needs a publint script added, or this silent skipping is unintentional.
Additional Locations (1)
Greptile OverviewGreptile SummaryRefactored the publint execution in the release workflow by centralizing it into a single script command. The change replaces three individual workspace-specific
Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, no comments
|
🎉 This PR is included in version 1.0.7 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Note
Simplifies release linting by adding a workspace-wide publint script and using it in the release workflow.
.github/workflows/release.yaml):npm run publint.package.json:publintscript that runs publint across workspaces.Written by Cursor Bugbot for commit 7ba5bb9. This will update automatically on new commits. Configure here.