fix(i18n): complete zh-CN translations for workspace, mascot, MCP Ser…#2440
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughTwo Simplified Chinese i18n chunk files are updated (vault workflow in ChangesSimplified Chinese Translation Updates
Security Audit Document
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…ver panels Translate 25 previously-untranslated UI strings across workspace vault controls, appearance helper text, mascot settings, and MCP Server settings panel. Placeholder values (CPU/GPU/RAM), technical examples (localhost URLs, API key formats), and brand names (OpenHuman, Composio) remain in English.
…ver panels Translate 25 previously-untranslated UI strings across workspace vault controls, appearance helper text, mascot settings, and MCP Server settings panel. Placeholder values (CPU/GPU/RAM), technical examples (localhost URLs, API key formats), and brand names (OpenHuman, Composio) remain in English.
graycyrus
left a comment
graycyrus
left a comment
There was a problem hiding this comment.
Nice work filling in the remaining zh-CN gaps — the MCP Server and mascot sections needed this.
One minor terminology nit below; otherwise this looks good.
| 'workspace.buildSummaryTrees': '构建摘要树', | ||
| 'workspace.viewVault': '查看存储库', | ||
| 'workspace.openingVaultTitle': 'Opening vault in Obsidian', | ||
| 'workspace.openingVaultTitle': '在 Obsidian 中打开保险库', |
There was a problem hiding this comment.
[minor] Inconsistent vault terminology — the existing workspace.viewVault on line 35 translates vault as 存储库, but these new strings use 保险库 (bank vault / safe). Chinese Obsidian users typically see 仓库 or 存储库 for vault.
Pick one term and use it everywhere. Matching the existing 存储库 is probably the lowest-friction fix:
| 'workspace.openingVaultTitle': '在 Obsidian 中打开保险库', | |
| 'workspace.openingVaultTitle': '在 Obsidian 中打开存储库', |
(Same change needed for openVaultFailedTitle, openVaultFailedMessage, and revealVaultFailed.)
There was a problem hiding this comment.
Good catch! Fixed in the latest commit — unified all vault references to "存储库" to match the existing translation on line 35. Thanks for the review!
Replaced 保险库 with 存储库 across workspace vault strings to match existing workspace.viewVault translation.
Initial security audit covering: - Module map (66 domain modules) - Credential and token flows - Trust boundaries and attack surface - MCP server config file permissions - Prompt injection guard coverage - Recommended next steps for maintainers
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/SECURITY_AUDIT.md`:
- Around line 51-55: Add explicit language identifiers (e.g., ```text) to each
fenced code block in SECURITY_AUDIT.md so they pass markdownlint MD040; find the
blocks that show the API/flow snippets such as the one containing
publish_global(DomainEvent), register_native_global, request_native_global, the
block referencing External message → channels/runtime/dispatch.rs and
agent.run_turn/agent/bus.rs, the Tool call block that mentions memory.recall and
stm_recall(), the Frontend settings block, the list block containing
memory_recall_memories / memory_recall_context / thread_turn_state_lifecycle /
wallet_setup_round_trips_status / tool_registry_lists_and_gets_entries, and the
mapping block with agent.run_turn and memory.sync, and prefix each opening fence
with "text" (```text) to satisfy the linter.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ee324de3-42a8-400d-b3b6-dc5cbf7ff774
📒 Files selected for processing (1)
docs/SECURITY_AUDIT.md
graycyrus
left a comment
graycyrus
left a comment
There was a problem hiding this comment.
Looks good, nice work!
2 participants
fix(i18n): complete zh-CN translations for workspace, mascot, MCP Server panels
Summary
Problem
25 UI strings were showing English values despite zh-CN locale being selected.
Solution
Added Chinese translations for full sentences and UI labels. Technical placeholders (CPU/GPU/RAM), example URLs, and brand names (OpenHuman, Composio) remain in English per project convention.
Submission Checklist
Summary by CodeRabbit