Open
Conversation
Expose ability to use SANY Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Propagate CLI parameter to Tlapm_lib Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Added Xmlm library dependency Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
Signed-off-by: Andrew Helwer <ahelwer@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The big files to look at here are:
src/sany/xml.ml: this shells out to SANY and parses its output into a collection of typed datastructures that reflect the XML output format; the XML output format documentation was added in XML Exporter: add comprehensive documentation to schema file tlaplus#1346)src/sany/sany.ml: this takes the datastructures generated bysrc/sany/xml.mland converts it into TLAPM's existing parse treeThe rest is test code, and modifications to
Tlapm_libto add entrypoints to the SANY functionality hidden behind a feature flag.The current status of the work is as follows:
VARIABLES x, yasVARIABLE xthenVARIABLE y) but after accounting for these comparing the S-expression output is a very nice way to spot differences. S-expression export has not yet been added on the SANY side.Ref #213