Fix issue #113: Prevent PaddingOracleAttacker from running endlessly#136
Open
Fix issue #113: Prevent PaddingOracleAttacker from running endlessly#136
Conversation
- Add early termination conditions in PaddingOracleAttacker: - Stop after 20 consecutive fingerprint extraction failures - Stop when failure rate exceeds 75% after processing at least 10 vectors - Add maximum runtime limit of 20 minutes in PaddingOracleProbe - Add try-catch blocks in PaddingOracleProbe to handle individual test failures gracefully - Log statistics about failures to help diagnose connectivity issues This prevents the scanner from appearing to hang when testing servers that are unresponsive or have connectivity issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #113
This PR addresses the issue where
PaddingOracleAttackercan run for hours while producing thousands of warnings when testing certain targets.Changes Made
PaddingOracleAttacker.java
MAX_CONSECUTIVE_FAILURESconstant (20) - stops testing after 20 consecutive fingerprint extraction failuresMAX_FAILURE_RATEconstant (0.75) - stops testing when more than 75% of attempts fail (after at least 10 attempts)createVectorResponseList()methodPaddingOracleProbe.java
MAX_PROBE_RUNTIME_MSconstant (20 minutes) - ensures probe completes in reasonable timePaddingOracleProbeTest.java
Test Plan
Notes
The fix uses a two-pronged approach:
This ensures the scanner remains responsive even when testing servers with connectivity issues or other problems that prevent successful fingerprint extraction.