Add decodeToMap method to directly parse a string into a Map<String, Object>#55
Closed
Asintotoo wants to merge 10 commits intotoon-format:mainfrom
Closed
Add decodeToMap method to directly parse a string into a Map<String, Object>#55Asintotoo wants to merge 10 commits intotoon-format:mainfrom
Asintotoo wants to merge 10 commits intotoon-format:mainfrom
Conversation
jenspapenhagen
requested changes
Nov 22, 2025
felipestanzani
requested changes
Nov 25, 2025
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| @Tag("unit") | ||
| public class JToonDecodeToMapTest { |
Collaborator
There was a problem hiding this comment.
The tests are lacking nesting examples. The edge cases must also be considered.
Collaborator
|
Could you make your review, @jenspapenhagen? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
decodeToMapmethod as a wrapper arounddecode(String)anddecode(String, DecodeOptions)that directly parses a string into a Map<String, Object>. No manual casting is required. If the result is null or invalid, an empty map is returned.Type of Change
Related Issues
Closes #
Changes Made
JToon.decodeToMap(String, DecodeOptions)methodJToon.decodeToMap(String)methodSPEC Compliance
Testing
Test Output
# Paste test output hereCode Quality
./gradlew test- all tests pass./gradlew jacocoTestCoverageVerification- coverage meets 85% thresholdChecklist
Performance Impact
Breaking Changes
Screenshots / Examples
Output:
Additional Context
Checklist for Reviewers