Skip to content

Allow per-form override of settings.TBXFORMS_HIGHLIGHT_REQUIRED_FIELDS #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 9, 2025
Merged

Allow per-form override of settings.TBXFORMS_HIGHLIGHT_REQUIRED_FIELDS #97

merged 3 commits into from
Jun 9, 2025

Conversation

@bmispelon
Copy link
Contributor

@bmispelon bmispelon commented Jun 3, 2025 •
edited by kbayliss
Loading

Addresses #96

@bmispelon bmispelon mentioned this pull request Jun 3, 2025
Closed
@kbayliss kbayliss linked an issue Jun 3, 2025 that may be closed by this pull request
Allow overriding settings.TBXFORMS_HIGHLIGHT_REQUIRED_FIELDS per form #96
Closed
@bmispelon bmispelon force-pushed the tmp-per-form-highlight-required branch from 2b6c8fa to 70cd343 Compare June 3, 2025 12:12
@bmispelon bmispelon force-pushed the tmp-per-form-highlight-required branch from 70cd343 to 19d225c Compare June 3, 2025 12:16
@bmispelon bmispelon marked this pull request as ready for review June 3, 2025 12:17
@bmispelon bmispelon requested a review from kbayliss as a code owner June 3, 2025 12:17
@bmispelon
Copy link
Contributor Author

bmispelon commented Jun 3, 2025

@kbayliss The PR should be ready for review. I tried to also add documentation and tests, let me know if there's something missing. Thanks!

kbayliss
kbayliss requested changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@kbayliss kbayliss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmispelon This is a great addition and all looks mega, thanks!

I've added a small suggestion. When do you need this by? If I release it on Friday, would that be okay, or do you need it sooner?

@bmispelon
Copy link
Contributor Author

bmispelon commented Jun 3, 2025

Amazing, thanks for the quick review! 🙏🏻

I've added a small suggestion. When do you need this by? If I release it on Friday, would that be okay, or do you need it sooner?

There's no rush on our end I don't think. We've got a CSS workaround for now, so there's no pressure to make a release. I'll take a look at your suggestion tomorrow (my brain also struggles with all the boolean combinations in that test 😅 ).

@kbayliss kbayliss enabled auto-merge (squash) June 9, 2025 11:06
@kbayliss kbayliss merged commit 7d74a0a into torchbox:main Jun 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbayliss kbayliss kbayliss approved these changes

Assignees

@bmispelon bmispelon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow overriding settings.TBXFORMS_HIGHLIGHT_REQUIRED_FIELDS per form

2 participants

@bmispelon @kbayliss