Skip to content

Wagtail 72 maintenance #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Wagtail 72 maintenance #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4d0183
Update requirements for Python 3.14 and Wagtail 7.2
nickmoreton Nov 12, 2025
b4e234a
Update GitHub Actions to test against Python 3.14
nickmoreton Nov 12, 2025
ce755c4
Update CHANGELOG
nickmoreton Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ env:
TOX_TESTENV_PASSENV: FORCE_COLOR
PIP_DISABLE_PIP_VERSION_CHECK: "1"
PIP_NO_PYTHON_VERSION_WARNING: "1"
PYTHON_LATEST: "3.13"
PYTHON_LATEST: "3.14"


jobs:
Expand All @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python: ["3.9", "3.10", "3.11", "3.12", "3.13"]
python: ["3.10", "3.11", "3.12", "3.13", "3.14"]

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ ci:
autofix_prs: false

default_language_version:
python: python3.13
python: python3.14

repos:
- repo: https://github.com/pre-commit/pre-commit-hooks
Expand All @@ -19,7 +19,7 @@ repos:
- id: trailing-whitespace
- repo: https://github.com/astral-sh/ruff-pre-commit
# Keep in sync with .github/workflows/ruff.yml
rev: 'v0.14.2'
rev: 'v0.14.4'
hooks:
- id: ruff
args: [--fix, --exit-non-zero-on-fix]
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

- Remove support for Wagtail <7.0, Python < 3.10
- Update tox testing to include Wagtail 7.2
- Include Python 3.14 in testing

## 0.14.0

- Remove support for Wagtail <6.3, Python < 3.9
Expand Down
13 changes: 6 additions & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,33 +17,32 @@ classifiers = [
"License :: OSI Approved :: MIT License",
"Programming Language :: Python",
"Programming Language :: Python :: 3",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Framework :: Django",
"Framework :: Django :: 4.2",
"Framework :: Django :: 5.1",
"Framework :: Django :: 5.2",
"Framework :: Wagtail",
"Framework :: Wagtail :: 6",
"Framework :: Wagtail :: 7",
]

dynamic = ["version"] # will read __version__ from wagtail_footnotes/__init__.py
requires-python = ">=3.9"
dependencies = [
"Wagtail>=6.3",
"Wagtail>=7.0",
Copy link
Member

@zerolab zerolab Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in two minds about this. 6.3 as an LTS is supported untill May 2026.
At the same time, it would be nice to push folks to move to at least 7.0

"Django>=4.2",
]

[project.optional-dependencies]
testing = [
"pre-commit>=4.3",
"tox>=4.22,<5",
"coverage>=7.10.6,<8.0",
"wagtail-modeladmin>=2.0.0",
"pre-commit>=4.4",
"tox>=4.32,<5",
"coverage>=7.11,<8.0",
"wagtail-modeladmin>=2.2.0",
]

[project.urls]
Expand Down
14 changes: 8 additions & 6 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
[tox]
min_version = 4.22
min_version = 4.32
skipmissing_interpreters = true

envlist =
python{3.9,3.10}-django4.2-wagtail{6.3}
python{3.10,3.11}-django5.1-wagtail{7.0,7.1}
python{3.12,3.13}-django5.2-wagtail{7.0,7.1}
python{3.10,3.11,3.12}-django4.2-wagtail{7.0,7.1,7.2}
python{3.10,3.11,3.12,3.13}-django{5.1,5.2}-wagtail{7.0,7.1,7.2}
python3.14-django5.2-wagtail{7.0,7.1,7.2}
Comment on lines +6 to +8
Copy link
Member

@zerolab zerolab Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about

Suggested change
python{3.10,3.11,3.12}-django4.2-wagtail{7.0,7.1,7.2}
python{3.10,3.11,3.12,3.13}-django{5.1,5.2}-wagtail{7.0,7.1,7.2}
python3.14-django5.2-wagtail{7.0,7.1,7.2}
python{3.10,3.11}-django4.2-wagtail{7.1}
python{3.12,3.13}-django{5.1,5.2}-wagtail{7.0,7.2}
python3.14-django5.2-wagtail{7.2}

smaller test matrix, but still covers what we need


[gh-actions]
python =
3.9: python3.9
3.10: python3.10
3.11: python3.11
3.12: python3.12
3.13: python3.13
3.14: python3.14


[testenv]
Expand All @@ -28,15 +29,16 @@ pass_env =
set_env =
python3.12: COVERAGE_CORE=sysmon
python3.13: COVERAGE_CORE=sysmon
python3.14: COVERAGE_CORE=sysmon

deps =
django4.2: Django>=4.2,<4.3
django5.1: Django>=5.1,<5.2
django5.2: Django>=5.2,<5.3

wagtail6.3: wagtail>=6.3,<6.4
wagtail7.0: wagtail>=7.0,<7.1
wagtail7.1: wagtail>=7.1,<7.2
wagtail7.2: wagtail>=7.2,<7.3


extras = testing
Expand Down