Normalise device address before resolution#108
Open
klochowicz wants to merge 2 commits into
Open
Conversation
IOBluetoothDevice's deviceWithAddressString: silently fails for two
specific input shapes: hyphenated all-lowercase ("aa-bb-cc-dd-ee-ff")
and no-separator all-uppercase ("AABBCCDDEEFF"). Other case and
separator combinations parse correctly.
Normalise the regex-validated input to colon-separated lowercase
before resolution; that form parses correctly in every combination.
Owner
|
Thanks for opening the PR blueutil --info aabbccddeeff
blueutil --info aabbccDDEEFF
blueutil --info AABBCCDDEEFF
blueutil --info aa-bb-cc-dd-ee-ff
blueutil --info aa-bb-cc-DD-EE-FF
blueutil --info AA-BB-CC-DD-EE-FF
blueutil --info aa:bb:cc:dd:ee:ff
blueutil --info aa:bb:cc:DD:EE:FF
blueutil --info AA:BB:CC:DD:EE:FF |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IOBluetoothDevice deviceWithAddressString:silently returnsnilfor two specific input shapes — hyphen-separated all-lowercase (aa-bb-cc-dd-ee-ff) and no-separator all-uppercase (AABBCCDDEEFF) — even though both already pass the regex incheck_device_address_arg. Other case/separator combinations parse correctly../testthat resolves every case/separator variant of the first paired device's address via--info. Skipped silently when no paired device is available, so the harness still works on a virgin machine.