Fix deadlock when copy #1041
Merged
Fix deadlock when copy #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggui
approved these changes
Nov 14, 2025
crates/cubecl-common/src/device.rs
Outdated
Comment on lines
382
to
385
| state: Option<( | ||
| HashMap<Key, DeviceStateLock>, | ||
| HashMap<TypeId, Arc<ReentrantMutex<()>>>, | ||
| )>, |
Member
There was a problem hiding this comment.
We should make this into a type, will make field accesses more explicit too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're locking two contexts at the same time, deadlocks were possible. I added a device-kind lock, which fixes that problem while still keeping the convenience of having multiple mutable contexts locked at once.