-
Notifications
You must be signed in to change notification settings - Fork 116
RMSnorm kernel and benchmark #973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huy209vn
wants to merge
15
commits into
tracel-ai:main
Choose a base branch
from
huy209vn:feat/rmsnorm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,554
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-em1880 Restore cubecl-attention lint allows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements RMS Normalization with support for bias, configurable epsilon, and runtime vectorization.
Includes fully verified CUDA benchmark and backend tests across CPU, WGPU, HIP.
Status
✅ Kernel: finalized, verified across dtypes (F32, F16, BF16)
✅ Benchmarks: refactored, stable, true GPU-time measurement
✅ Tests: cross-backend validation vs CPU reference
Kernel Notes
-
-
-
-
-
-
-
Benchmark Results (RTX 3090, CUDA)Two variants:
streaming — minimal register pressure (default)
smem — kept for future optimization, currently disabled
Vectorization:
vec=8(F32),vec=4(F16/BF16)Enforces ≥512 threads for occupancy
Avoids register spills via
MAX_LINES_PER_THREAD=4Uses fast reciprocal sqrt when supported
Shape: [8, 1024, 4096] (33.55M elements)
Shape: [16, 1024, 4096] (67.11M elements)
Shape: [32, 2048, 4096] (268.44M elements)
Shape: [64, 4096, 4096] (1073.74M elements)
✅ No regressions.
✅ All dtypes saturate memory bandwidth as expected.
Commands
Env Overrides