-
Notifications
You must be signed in to change notification settings - Fork 206
Add SunSwap project to defiProjectList.json #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added SunSwap project details to the defiProjectList.
jesusgutn6-maker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{
"name": "SunSwap",
"logoURI": "https://coin.top/production/upload/logo/sun10.png",
"homepage": "http://sun.io/",
"MarketCapLink": "https://coinmarketcap.com/currencies/sun-token",
"url": "https://apilist.tronscan.org/api/tvl",
"category": "DEX",
"poolAddresses": [
"TKcEU8ekq2ZoFzLSGFYCUY6aocJBX9X31b",
"TCbzPNRqy1twLz5jTr28Wbuvashou53UQB"
]
}
|
{ |
|
Enlace de Twitter: |
1 similar comment
|
Enlace de Twitter: |
jesusgutn6-maker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defiProjectList.json
jesusgutn6-maker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a quick review, a JSON validation/fix, a consistency check against the repo schema, or for me to add a review comment/update the PR?
Quick review of the diff you pasted:
- Intent: adding a SunSwap entry to defiProjectList.json — looks fine conceptually.
- JSON validity: the object itself is valid, but make sure surrounding array items (commas) and trailing newline are correct in the full file.
- Field names: you use "MarketCapLink" (camel case with capital M and C). I recommend matching the exact casing used elsewhere in the repo — I can search the repo to confirm the canonical key if you want.
- URL fields:
- logoURI: https://coin.top/production/upload/logo/sun10.png — accessible? (I can't fetch it here; you may want to confirm the image is reachable).
- url: https://apilist.tronscan.org/api/tvl — this is a general Tronscan API endpoint; confirm it returns the expected TVL for SunSwap or if a more specific endpoint (with query params or path) is required.
- poolAddresses: TRON addresses start with 'T' and these look syntactically plausible. Confirm they are the intended pools and active.
If helpful, here is a clean minimal snippet you can use (replace key casing if the repo uses a different naming convention):
[
{
"name": "SunSwap",
"logoURI": "https://coin.top/production/upload/logo/sun10.png",
"homepage": "http://sun.io/",
"MarketCapLink": "https://coinmarketcap.com/currencies/sun-token",
"url": "https://apilist.tronscan.org/api/tvl",
"category": "DEX",
"poolAddresses": [
"TKcEU8ekq2ZoFzLSGFYCUY6aocJBX9X31b",
"TCbzPNRqy1twLz5jTr28Wbuvashou53UQB"
]
}
]
Next steps I can do for you (pick one):
- Search the repository for the canonical field names and update the entry to match.
- Validate the full JSON file and fix formatting issues (commas, trailing newline).
- Post a PR review comment summarizing suggested changes.
- Update the PR file directly with a corrected version.
Which would you like?
jesusgutn6-maker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want a quick review, a JSON validation/fix, a consistency check against the repo schema, or for me to add a review comment/update the PR?
Quick review of the diff you pasted:
- Intent: adding a SunSwap entry to defiProjectList.json — looks fine conceptually.
- JSON validity: the object itself is valid, but make sure surrounding array items (commas) and trailing newline are correct in the full file.
- Field names: you use "MarketCapLink" (camel case with capital M and C). I recommend matching the exact casing used elsewhere in the repo — I can search the repo to confirm the canonical key if you want.
- URL fields:
- logoURI: https://coin.top/production/upload/logo/sun10.png — accessible? (I can't fetch it here; you may want to confirm the image is reachable).
- url: https://apilist.tronscan.org/api/tvl — this is a general Tronscan API endpoint; confirm it returns the expected TVL for SunSwap or if a more specific endpoint (with query params or path) is required.
- poolAddresses: TRON addresses start with 'T' and these look syntactically plausible. Confirm they are the intended pools and active.
If helpful, here is a clean minimal snippet you can use (replace key casing if the repo uses a different naming convention):
[
{
"name": "SunSwap",
"logoURI": "https://coin.top/production/upload/logo/sun10.png",
"homepage": "http://sun.io/",
"MarketCapLink": "https://coinmarketcap.com/currencies/sun-token",
"url": "https://apilist.tronscan.org/api/tvl",
"category": "DEX",
"poolAddresses": [
"TKcEU8ekq2ZoFzLSGFYCUY6aocJBX9X31b",
"TCbzPNRqy1twLz5jTr28Wbuvashou53UQB"
]
}
]
Next steps I can do for you (pick one):
- Search the repository for the canonical field names and update the entry to match.
- Validate the full JSON file and fix formatting issues (commas, trailing newline).
- Post a PR review comment summarizing suggested changes.
- Update the PR file directly with a corrected version.
Which would you like?
Added SunSwap project details to the defiProjectList.
Please provide the following information for your Defi project.
Please include change to the
defiProjectList.jsonfile in the PR.DON'T modify any other project's contents.
Twitter Link:
List of audit links if any:
Homepage:
Logo (High resolution, preferably in .svg and .png, for application on both white and black backgrounds. Will be shown with rounded borders):
URL to get TVL:
Current TVL:
MarketCap link (so your TVL can appear on Coinmarketcap or Coingecko): (https://coinmarketcap.com/currencies/#TOKEN or https://www.coingecko.com/en/coins/#TOKEN)
Short Description:
Token address and ticker if any:
Pool addresses:
Category (Yield/DEX/Lending/Minting/Assets/Insurance/Options/Indexes/Staking) *Please choose only one:
Oracle used (WINkLink/Chainlink/Band/API3/TWAP or any other that you are using):
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):