[WIP] Refactor graph_connect.go for better readability#69
[WIP] Refactor graph_connect.go for better readability#69akokhanovskyi wants to merge 10 commits intotrustmaster:masterfrom
Conversation
…nnect.go for readability
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 89.47% 87.61% -1.86%
==========================================
Files 6 7 +1
Lines 304 323 +19
==========================================
+ Hits 272 283 +11
- Misses 17 26 +9
+ Partials 15 14 -1
Continue to review full report at Codecov.
|
| const scalingFactor = 2 | ||
|
|
||
| if port.Cap() <= key { | ||
| port.SetCap(2 * key) |
There was a problem hiding this comment.
Note that this is guaranteed to panic. To "extend" the underlying array, you have to reallocate the slice and copy the data.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
- Coverage 89.43% 88.30% -1.14%
==========================================
Files 6 7 +1
Lines 303 342 +39
==========================================
+ Hits 271 302 +31
- Misses 17 22 +5
- Partials 15 18 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This is WIP, please do not merge yet; comments are welcome!