Open
Conversation
Member
jeromekelleher
left a comment
jeromekelleher
left a comment
There was a problem hiding this comment.
Why do we need to upgrade SLiM? Does 3.7 not compile any more or something?
Contributor
Author
|
Yes, I could not compile 3.7 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2438 +/- ##
=======================================
Coverage 91.23% 91.23%
=======================================
Files 20 20
Lines 11831 11831
Branches 2296 2296
=======================================
Hits 10794 10794
Misses 568 568
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slim script modifciations and add output to gitignore Update Makefile and development documentation for verification process Comment out test for GC tract length as it is not supported in SmcKApproxCoalescent cycle instead of tick comment smck test for gc
hossam26644
force-pushed
the
update_verification
branch
from
c7d89a4 to
3ef9eb2
Compare
Member
|
I don't know enough about SLiM to check this. @petrelharp would you mind taking a quick look over the SLiM changes here (necessary for the upgrade from 3.7) to see if they are equivalent? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update the verification pipeline: