Fix/golang with tsuru yaml #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update post_deploy to only copy default Procfile if neither Procfile nor tsuru.yml/yaml exist in CURRENT_DIR. Adjust formatting for diff output and case statement for clarity and consistency.
Refactor os_dependencies to use keyrings for APT repositories, replacing the deprecated apt-key with gpg and signed-by options. Improve repository and PPA handling for security and maintainability. Expand and clarify BATS tests to cover deb, deb-src, ppa, and ppa with fingerprint scenarios, ensuring robust verification of sources and keyrings.
Replace the pogo-dev PPA with the graphics-drivers PPA in the test for adding extra APT repositories from repositories.apt. The new PPA is widely available and maintained across Ubuntu 20.04, 22.04, 24.04, and latest, ensuring better reliability and compatibility for CI runs.
Refactor post_deploy to better determine when to copy the default Procfile. Now, if a Procfile is missing, the script checks for a tsuru.yml or tsuru.yaml file and inspects it for a valid 'processes' section with at least one process definition (both 'name' and 'command'). Only if no such process is found does it copy the default Procfile. This prevents unnecessary Procfile creation when the tsuru config already defines processes.
Add BATS tests to verify that the default Procfile is copied when `tsuru.yml` does not define processes, and not copied when processes are defined in `tsuru.yaml`. This ensures correct Procfile handling during deployment.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Golang deployment compatibility with tsuru.yml configuration files by improving the logic for determining when to use default Procfiles and updating APT repository management to use modern GPG key handling.
- Enhanced post-deploy logic to check for process definitions in both tsuru.yml and tsuru.yaml files before using default Procfile
- Modernized APT repository key management by replacing deprecated apt-key with gpg keyring management
- Improved test coverage for various APT repository formats and tsuru configuration scenarios
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| base/deploy | Enhanced post_deploy function to parse tsuru.yml/yaml files and conditionally use default Procfile |
| base/rc/os_dependencies | Modernized APT key management using gpg keyrings instead of deprecated apt-key |
| test/tests.bats | Added comprehensive tests for tsuru.yml process detection and updated APT repository tests |
| .github/workflows/ci.yaml | Added pull_request trigger to CI workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.