Extend tournament edit page by playoff generation variables #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 17, 2019
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-google'
Cannot find module 'eslint-config-google'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-google'
at ModuleResolver.resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:479:28)
at load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:551:26)
at configExtends.reduceRight (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:425:36)
at Array.reduceRight ()
at applyExtends (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:403:26)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:523:22)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
JP1998
force-pushed
the
ticket/TURNIERE-245
branch
from
4822200 to
1c9c6b2
Compare
houndci-bot
reviewed
Jun 18, 2019
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-google'
Cannot find module 'eslint-config-google'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-google'
at ModuleResolver.resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:479:28)
at load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:551:26)
at configExtends.reduceRight (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:425:36)
at Array.reduceRight ()
at applyExtends (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:403:26)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:523:22)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
houndci-bot
reviewed
Jun 18, 2019
houndci-bot
left a comment
houndci-bot
left a comment
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-google'
Cannot find module 'eslint-config-google'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-google'
at ModuleResolver.resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:479:28)
at load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:551:26)
at configExtends.reduceRight (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:425:36)
at Array.reduceRight ()
at applyExtends (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:403:26)
at loadFromDisk (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:523:22)
at Object.load (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config/config-file.js:559:20)
at Config.getLocalConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:227:44)
at Config.getConfigHierarchy (/home/linters/app/versions/eslint-4.18.2/node_modules/eslint/lib/config.js:179:43)
betanummeric
changed the title
betanummeric
requested changes
Oct 1, 2019
Contributor
betanummeric
left a comment
betanummeric
left a comment
There was a problem hiding this comment.
The input fields are shown in tournaments that do not have a group stage. According to the ticket TURNIERE-245 the input fields should be hidden in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must be reviewed after #40 because I forgot to switch to master before branching :)