Skip to content

Conversation

@patrickhlauke
Copy link
Member

Fixes the (valid) complaint from vnu #2221 (comment)

Fixes the (valid) complaint from vnu #2221 (comment)
@patrickhlauke patrickhlauke marked this pull request as draft December 4, 2025 09:50
@patrickhlauke
Copy link
Member Author

Ah, actually, I forgot that that <div> in large viewport is just a regular container that is actually visible. so dialog won't be appropriate. let me tweak this...

@patrickhlauke patrickhlauke changed the title Add role="dialog" directly to the offcanvas Add role="region" directly to the offcanvas Dec 4, 2025
@patrickhlauke patrickhlauke marked this pull request as ready for review December 4, 2025 12:33
@patrickhlauke
Copy link
Member Author

the fact that the offcanvas script doesn't keep track of whether or not the container had a role to begin with, and after closing simply deletes the role attribute altogether...is probably not ideal. but that's a different problem to tackle (scripts that add and remove things like roles should really make sure they return gracefully to whatever the author had originally specified in markup)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants