fix: prevent NullPointerException in Page.buildNextGenPage#935
Open
Nepomuk5665 wants to merge 2 commits intotwilio:mainfrom
Open
fix: prevent NullPointerException in Page.buildNextGenPage#935Nepomuk5665 wants to merge 2 commits intotwilio:mainfrom
Nepomuk5665 wants to merge 2 commits intotwilio:mainfrom
Conversation
Add null checks before calling isNull() on JsonNode objects retrieved from meta object. The meta.get() method returns null (Java null) when the key doesn't exist, and calling isNull() on a null reference throws NullPointerException. This fix aligns buildNextGenPage with the pattern already used in buildPage, which correctly checks 'node != null && !node.isNull()' before accessing the node's value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential NullPointerException in the
Page.buildNextGenPagemethod that can occur when parsing JSON responses from next-gen API endpoints.Bug Description
In
buildNextGenPage, the code retrievesJsonNodevalues from themetaobject and calls.isNull()on them without first checking if they arenull:The
meta.get("key")method returns Javanullwhen the key doesn't exist in the JSON. Calling.isNull()on anullreference throwsNullPointerException.Fix
Added null checks before calling
.isNull(), following the same pattern already used in thebuildPagemethod:Affected Fields
next_page_urlprevious_page_urlfirst_page_urlpage_sizeAll four fields now have proper null checks.
Testing
The fix follows the existing pattern in
buildPage(lines 153-173) which correctly handles this case.