Skip to content

feat(utxorpc): implement mapping of genesis configuration to UTxO RPC Genesis type #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hrmtm23 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(utxorpc): implement mapping of genesis configuration to UTxO RPC Genesis type #689

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34aa943
feat(utxorpc): implement mapping of genesis configuration to UTxO RPC…
hrmtm23 Aug 15, 2025
8a3341c
Merge branch 'main' into chore/update-utxorpc-dependencies
hrmtm23 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pallas-configs/src/byron.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ pub type BootStakeWeight = u16;
#[derive(Debug, Deserialize, Clone)]
#[serde(rename_all = "camelCase")]
pub struct HeavyDelegation {
pub omega: u32,
pub issuer_pk: String,
pub delegate_pk: String,
pub cert: String,
Expand Down
145 changes: 145 additions & 0 deletions pallas-traverse/src/wellknown.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,18 @@ pub struct GenesisValues {
pub shelley_known_slot: u64,
pub shelley_known_hash: String,
pub shelley_known_time: u64,

// Hard Fork Combinator (HFC) era transition slots
#[serde(default)]
pub allegra_start_slot: Option<u64>,
#[serde(default)]
pub mary_start_slot: Option<u64>,
#[serde(default)]
pub alonzo_start_slot: Option<u64>,
#[serde(default)]
pub babbage_start_slot: Option<u64>,
#[serde(default)]
pub conway_start_slot: Option<u64>,
}

impl GenesisValues {
Expand All @@ -51,6 +63,13 @@ impl GenesisValues {
shelley_known_hash: "aa83acbf5904c0edfe4d79b3689d3d00fcfc553cf360fd2229b98d464c28e9de"
.to_string(),
shelley_known_time: 1596059091,

// Era transitions - source: official Cardano documentation
allegra_start_slot: Some(16588800),
mary_start_slot: Some(23068800),
alonzo_start_slot: Some(39916975),
babbage_start_slot: Some(72316896),
conway_start_slot: Some(133660855),
}
Comment on lines +67 to 73
Copy link

@coderabbitai coderabbitai bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

Verify mainnet transition slots.

Hardcoded slots for Allegra/Mary/Alonzo/Babbage/Conway must match canonical sources.

🌐 Web query:

Confirm Cardano mainnet era transition absolute slot numbers for: Allegra, Mary, Alonzo, Babbage, Conway.
Return authoritative sources.

💡 Result:

Here are the mainnet era-transition absolute slot boundaries (last absolute slot of the previous era) with authoritative sources:

  • Allegra → Mary: last Allegra absolute slot = 23,068,793. [1]
  • Mary → Alonzo: last Mary absolute slot = 39,916,796. [1]
  • Alonzo → Babbage: last Alonzo absolute slot = 72,316,796. [1]
  • Babbage → Conway: last Babbage absolute slot = 133,660,799. [1]

(Therefore the next-era first absolute slot = last-slot + 1 for each transition.)

Sources:
[1] Ogmios — Chain synchronization / “Points of interest” (mainnet era-boundaries with absolute slot numbers). [2] Cardano Wallet — Eras (explanation of era-switching by on‑chain proposal). [1]: https://ogmios.dev/mini-protocols/local-chain-sync/ [2]: https://cardano-foundation.github.io/cardano-wallet/design/concepts/eras.html

If you want I can also return the exact first-slot-of-era values (last+1) and block hashes for those boundary blocks.

Fix era transition slots to match Cardano mainnet canonical values.

The hardcoded slot values do not match authoritative Ogmios and Cardano Wallet documentation. Correct values are:

  • mary_start_slot: 23068794 (currently 23068800)
  • alonzo_start_slot: 39916797 (currently 39916975)
  • babbage_start_slot: 72316797 (currently 72316896)
  • conway_start_slot: 133660800 (currently 133660855)
🤖 Prompt for AI Agents 
In pallas-traverse/src/wellknown.rs around lines 67 to 73, the hardcoded era
transition slot constants are incorrect; update the values to match Cardano
mainnet canonical sources by changing mary_start_slot to Some(23068794),
alonzo_start_slot to Some(39916797), babbage_start_slot to Some(72316797), and
conway_start_slot to Some(133660800) so the file uses the authoritative
Ogmios/Cardano Wallet slot numbers.

}

Expand All @@ -71,6 +90,13 @@ impl GenesisValues {
shelley_known_hash: "02b1c561715da9e540411123a6135ee319b02f60b9a11a603d3305556c04329f"
.to_string(),
shelley_known_time: 1595967616,

// Legacy testnet era transitions - not documented
allegra_start_slot: None,
mary_start_slot: None,
alonzo_start_slot: None,
babbage_start_slot: None,
conway_start_slot: None,
}
}

Expand All @@ -89,6 +115,13 @@ impl GenesisValues {
shelley_known_hash: "268ae601af8f9214804735910a3301881fbe0eec9936db7d1fb9fc39e93d1e37"
.to_string(),
shelley_known_time: 1666656000,

// Preview likely started in Babbage era
allegra_start_slot: None,
mary_start_slot: None,
alonzo_start_slot: None,
babbage_start_slot: None,
conway_start_slot: Some(31424418),
}
}

Expand All @@ -109,6 +142,13 @@ impl GenesisValues {
shelley_known_hash: "c971bfb21d2732457f9febf79d9b02b20b9a3bef12c561a78b818bcb8b35a574"
.to_string(),
shelley_known_time: 1655769600,

// Preprod era transitions - not documented
allegra_start_slot: None,
mary_start_slot: None,
alonzo_start_slot: None,
babbage_start_slot: None,
conway_start_slot: None,
}
}

Expand All @@ -123,6 +163,111 @@ impl GenesisValues {
_ => None,
}
}

/// Get era start slot using HFC data
pub fn era_start_slot(&self, era: crate::Era) -> Option<u64> {
use crate::Era;
match era {
Era::Byron => Some(0),
Era::Shelley => Some(self.shelley_known_slot),
Era::Allegra => self.allegra_start_slot,
Era::Mary => self.mary_start_slot,
Era::Alonzo => self.alonzo_start_slot,
Era::Babbage => self.babbage_start_slot,
Era::Conway => self.conway_start_slot,
}
}

/// Get era from slot number using HFC data
pub fn slot_to_era(&self, slot: u64) -> crate::Era {
use crate::Era;

if slot < self.shelley_known_slot {
Era::Byron
} else if self.allegra_start_slot.map_or(true, |s| slot < s) {
Era::Shelley
} else if self.mary_start_slot.map_or(true, |s| slot < s) {
Era::Allegra
} else if self.alonzo_start_slot.map_or(true, |s| slot < s) {
Era::Mary
} else if self.babbage_start_slot.map_or(true, |s| slot < s) {
Era::Alonzo
} else if self.conway_start_slot.map_or(true, |s| slot < s) {
Era::Babbage
} else {
Era::Conway
}
}
Comment on lines +181 to +200
Copy link

@coderabbitai coderabbitai bot Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Fix slot_to_era when intermediate era start slots are None.

Current map_or(true, …) short‑circuits to earlier eras; e.g., preview classifies everything as Shelley. Implement skip‑if‑None with rolling last‑known era.

Apply:

-    pub fn slot_to_era(&self, slot: u64) -> crate::Era {
-        use crate::Era;
-
-        if slot < self.shelley_known_slot {
-            Era::Byron
-        } else if self.allegra_start_slot.map_or(true, |s| slot < s) {
-            Era::Shelley
-        } else if self.mary_start_slot.map_or(true, |s| slot < s) {
-            Era::Allegra
-        } else if self.alonzo_start_slot.map_or(true, |s| slot < s) {
-            Era::Mary
-        } else if self.babbage_start_slot.map_or(true, |s| slot < s) {
-            Era::Alonzo
-        } else if self.conway_start_slot.map_or(true, |s| slot < s) {
-            Era::Babbage
-        } else {
-            Era::Conway
-        }
-    }
+    pub fn slot_to_era(&self, slot: u64) -> crate::Era {
+        use crate::Era;
+        if slot < self.shelley_known_slot {
+            return Era::Byron;
+        }
+        // List known transitions in order, skipping unknowns.
+        let transitions: &[(Era, Option<u64>)] = &[
+            (Era::Allegra, self.allegra_start_slot),
+            (Era::Mary, self.mary_start_slot),
+            (Era::Alonzo, self.alonzo_start_slot),
+            (Era::Babbage, self.babbage_start_slot),
+            (Era::Conway, self.conway_start_slot),
+        ];
+        let mut current = Era::Shelley;
+        for (era, maybe_start) in transitions {
+            if let Some(start) = maybe_start {
+                if slot < *start {
+                    return current;
+                }
+                current = *era;
+            }
+        }
+        current
+    }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
/// Get era from slot number using HFC data
pub fn slot_to_era(&self, slot: u64) -> crate::Era {
use crate::Era;
if slot < self.shelley_known_slot {
Era::Byron
} else if self.allegra_start_slot.map_or(true, |s| slot < s) {
Era::Shelley
} else if self.mary_start_slot.map_or(true, |s| slot < s) {
Era::Allegra
} else if self.alonzo_start_slot.map_or(true, |s| slot < s) {
Era::Mary
} else if self.babbage_start_slot.map_or(true, |s| slot < s) {
Era::Alonzo
} else if self.conway_start_slot.map_or(true, |s| slot < s) {
Era::Babbage
} else {
Era::Conway
}
}
pub fn slot_to_era(&self, slot: u64) -> crate::Era {
use crate::Era;
if slot < self.shelley_known_slot {
return Era::Byron;
}
// List known transitions in order, skipping unknowns.
let transitions: &[(Era, Option<u64>)] = &[
(Era::Allegra, self.allegra_start_slot),
(Era::Mary, self.mary_start_slot),
(Era::Alonzo, self.alonzo_start_slot),
(Era::Babbage, self.babbage_start_slot),
(Era::Conway, self.conway_start_slot),
];
let mut current = Era::Shelley;
for (era, maybe_start) in transitions {
if let Some(start) = maybe_start {
if slot < *start {
return current;
}
current = *era;
}
}
current
}
🤖 Prompt for AI Agents 
pallas-traverse/src/wellknown.rs around lines 181 to 200: slot_to_era currently
uses map_or(true, |s| slot < s) which treats missing (None) start slots as if
the era boundary is in the future and thus short‑circuits to earlier eras;
change the logic to skip None boundaries and only compare when a start slot is
Some. Implement a sequential check or a rolling approach: start with
Byron/Shelley decision using shelley_known_slot, then for each subsequent era
boundary (allegra, mary, alonzo, babbage, conway) only compare slot < start when
the Option is Some, otherwise skip that check and continue to the next boundary;
alternatively maintain a current_era and advance it only when a boundary is Some
and slot >= that boundary, then return the final current_era.


/// Get list of all known eras (regardless of whether slot data is available)
pub fn available_eras(&self) -> Vec<crate::Era> {
use crate::Era;
vec![
Era::Byron,
Era::Shelley,
Era::Allegra,
Era::Mary,
Era::Alonzo,
Era::Babbage,
Era::Conway,
]
}

/// Get list of eras that have slot transition data configured
pub fn eras_with_slot_data(&self) -> Vec<crate::Era> {
use crate::Era;
let mut eras = vec![Era::Byron, Era::Shelley]; // Always have these

if self.allegra_start_slot.is_some() {
eras.push(Era::Allegra);
}
if self.mary_start_slot.is_some() {
eras.push(Era::Mary);
}
if self.alonzo_start_slot.is_some() {
eras.push(Era::Alonzo);
}
if self.babbage_start_slot.is_some() {
eras.push(Era::Babbage);
}
if self.conway_start_slot.is_some() {
eras.push(Era::Conway);
}

eras
}

/// Configure era transition slots with known values
/// This allows users to provide accurate slot numbers when they have them
pub fn with_era_slots(
mut self,
allegra: Option<u64>,
mary: Option<u64>,
alonzo: Option<u64>,
babbage: Option<u64>,
conway: Option<u64>,
) -> Self {
self.allegra_start_slot = allegra;
self.mary_start_slot = mary;
self.alonzo_start_slot = alonzo;
self.babbage_start_slot = babbage;
self.conway_start_slot = conway;
self
}

/// Set a specific era's start slot
pub fn set_era_start_slot(&mut self, era: crate::Era, slot: Option<u64>) {
use crate::Era;
match era {
Era::Byron => {} // Byron always starts at slot 0
Era::Shelley => {} // Shelley slot is in known_slot field
Era::Allegra => self.allegra_start_slot = slot,
Era::Mary => self.mary_start_slot = slot,
Era::Alonzo => self.alonzo_start_slot = slot,
Era::Babbage => self.babbage_start_slot = slot,
Era::Conway => self.conway_start_slot = slot,
}
}
}

impl Default for GenesisValues {
Expand Down
5 changes: 3 additions & 2 deletions pallas-utxorpc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,14 @@ authors = ["Santiago Carmuega <[email protected]>"]

[dependencies]
# utxorpc-spec = { path = "../../../utxorpc/spec/gen/rust" }
utxorpc-spec = { version = "0.16.0" }
utxorpc-spec = { version = "0.17.0" }

pallas-traverse = { version = "=1.0.0-alpha.2", path = "../pallas-traverse" }
pallas-primitives = { version = "=1.0.0-alpha.2", path = "../pallas-primitives" }
pallas-codec = { version = "=1.0.0-alpha.2", path = "../pallas-codec" }
pallas-crypto = { version = "=1.0.0-alpha.2", path = "../pallas-crypto" }
prost-types = "0.13.1"
pallas-configs = { version = "=1.0.0-alpha.2", path = "../pallas-configs" }
prost-types = "0.14.1"
pallas-validate = { version = "=1.0.0-alpha.2", path = "../pallas-validate" }

[dev-dependencies]
Expand Down
Loading