Use array-backed buffer for incoming messages in 'StreamIngest'#819
Open
seigert wants to merge 2 commits intotypelevel:mainfrom
Open
Use array-backed buffer for incoming messages in 'StreamIngest'#819seigert wants to merge 2 commits intotypelevel:mainfrom
seigert wants to merge 2 commits intotypelevel:mainfrom
Conversation
Accumilated buffer will be converted to a `fs2.Chunk[T]` before emitting of stream messages.
seigert
force-pushed
the
stream-ingest-buffer
branch
from
a069189 to
dd7ad03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If value of
prefetchNoption set for client- or server-side streaming calls is bigger than some arbitrary threshold,fs2.Chunk.ArraySlicewill be used for incoming messages with shared array buffer underneath.Currently threshold is set to
prefetchN == 14so that minimal size of array is 128 bytes (12 + 4 + 14 * 8) for 'CompressedOops' pointers.Some benchmarks are needed to check if this optimisation is worthy of involved code complexity.