Do not fail on commands without exit status #1242
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisonbarbosa
force-pushed
the
fix-e2e-remote-commands
branch
from
1f59104 to
a9beabd
Compare
denisonbarbosa
force-pushed
the
fix-e2e-remote-commands
branch
4 times, most recently
from
9b2dffc to
940d172
Compare
denisonbarbosa
force-pushed
the
fix-e2e-remote-commands
branch
20 times, most recently
from
67fa251 to
22190b8
Compare
denisonbarbosa
force-pushed
the
fix-e2e-remote-commands
branch
from
22190b8 to
de19279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some commands are not returning an exit status anymore, so let's not fail on those. If they failed to run properly, it's very likely that other commands down the chain will also fail, so we don't need to worry about it too much.