Yaru Gnome Shell Theme: Added Visual Changes to Ubuntu Dock #4328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes includes Dropping the translucent background, fixing inconsistent padding and better background radius handling. * Dropping translucent background: dropping the translucent background and replacing it with background color as dark as the gnome shell popover elements helps with achieving better contrast. Once crucial feature of the dock that is affected by the translucent background is the separator. Some wallpaper practically makes the separator nearly invisible. A much darker border is also applied to panel mode but only on the side opposite to the current dock position. This helps achieve separation with full screen windows. * Fixing inconsistent padding: In panel mode, there is a behavior where the top and bottom padding (when dock is vertically oriented) is larger. The original shrunk padding is still kept. With the consistencies applied, calculating the dock radius when not in panel becomes more consistent. * Better background radius handling: The icon radius is changed and matched to popover item radius. With this change, dock radius is better handled and is calculated by the sum of the icon radius and the current dock padding. closes github.com/ubuntu/issues/4322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes includes Dropping the translucent background, fixing inconsistent padding and better background radius handling.
Dropping translucent background: dropping the translucent background and replacing it with background color as dark as the gnome shell popover elements helps with achieving better contrast. Once crucial feature of the dock that is affected by the translucent background is the separator. Some wallpaper practically makes the separator nearly invisible. A much darker border is also applied to panel mode but only on the side opposite to the current dock position. This helps achieve separation with full screen
windows.
Fixing inconsistent padding: In panel mode, there is a behavior where the top and bottom padding (when dock is vertically oriented) is larger. The original shrunk padding is still kept. With the consistencies applied, calculating the dock radius when not in panel becomes more consistent.
Better background radius handling: The icon radius is changed and matched to popover item radius. With this change, dock radius is better handled and is calculated by the sum of the icon radius and the current dock padding.
closes github.com//issues/4322