gnome-shell: Optimize contrast for warning, success and destructive texts #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3v1n0
force-pushed
the
error-messages-contrast-fix
branch
from
d92487c to
9917893
Compare
…exts In practice the shell only use the warning color, but optimize them all in case some extension relies on the other ones (yep, ubuntu-dock!) LP: #2126731
3v1n0
force-pushed
the
error-messages-contrast-fix
branch
from
9917893 to
6206ea9
Compare
Contributor
Author
|
/cc @juanruitina, @sergio-costas This is just using the automatic computation of the contrast. I'm uploading hoping to be in time for 25.10 😂 (I've another change but it's for another PR as I wanted to be minimal here), we can re-iterate in future. |
|
Thank you, definitely an improvement. I see the error in the last screenshot using ellipsis instead of wrapping: the kind of thing that we miss when the system is in English. Would be good to get that fixed. |
Contributor
Author
Sure, that's fixed too: https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3898 (tracked here ubuntu side) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice the shell only use the warning color, but optimize them all in case some extension relies on the other ones (yep, ubuntu-dock!)
Compare with original screenshots in #4320
Partially overrides #4320