Skip to content

Conversation

@dmols dmols self-requested a review October 2, 2025 17:24
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not particularly sure how to test the <canvas> and <input> specific condition changes for the AltText form, seeing as both are not allowed in Canvas. Could do so in an html file but since the file replacement feature is not fleshed out (iirc), it may be difficult to test if it works. Open to suggestions!

That said, I did test the rest of the issues fixed and I saw no errors pop up except for the "Heading Empty" and "Links Should be Descriptive" fix. This is what I saw when I tried to remove a heading.

Screen.Recording.2025-10-07.at.9.55.01.AM.mov

Same thing occurs for the links, though sometimes clicking "Show Content Preview" just loads a page with the word 'undefined' in it, like so:

Screenshot 2025-10-07 at 9 59 07 AM

Worth noting, I did clear my code cache and browser cache, and still encountered the same issue.

@mbusch3
Copy link
Contributor Author

mbusch3 commented Nov 13, 2025

@dmols Good catch there. This is a weird one.

So, it turns out that the local "activeContentItem" is getting saved with the new, updated version of the content BEFORE the save function is returning from the API. So if there is an issue, and the save DOESN'T complete for any reason, there will be a discrepancy between what is in the local version and what is in Canvas. A full course rescan fixes it, but that's obviously not the desired behavior.

The SECOND issue is that when you choose to delete the Heading in your example above, it really, really should not be throwing that "No changes, so I can't save" exception. I'm going to look into that first and the above issue next. Hope to have a fix today or tomorrow so we can get this PR wrapped up.

@mbusch3
Copy link
Contributor Author

mbusch3 commented Nov 24, 2025

@dmols As far as I can tell, the last commit should fix both issues: the php saving function doesn't choke on saving an empty string, and the front end shows the preview properly after the saving is complete.

@dmols dmols self-requested a review December 3, 2025 15:13
Copy link
Contributor

@dmols dmols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most recent changes look great, and the rest is working as intended still. Good work!

@dmols dmols merged commit 4ce5cd9 into ucfopen:new-main-page-UX Dec 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants