-
Notifications
You must be signed in to change notification settings - Fork 74
Several small bug fixes... #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not particularly sure how to test the <canvas> and <input> specific condition changes for the AltText form, seeing as both are not allowed in Canvas. Could do so in an html file but since the file replacement feature is not fleshed out (iirc), it may be difficult to test if it works. Open to suggestions!
That said, I did test the rest of the issues fixed and I saw no errors pop up except for the "Heading Empty" and "Links Should be Descriptive" fix. This is what I saw when I tried to remove a heading.
Screen.Recording.2025-10-07.at.9.55.01.AM.mov
Same thing occurs for the links, though sometimes clicking "Show Content Preview" just loads a page with the word 'undefined' in it, like so:
Worth noting, I did clear my code cache and browser cache, and still encountered the same issue.
|
@dmols Good catch there. This is a weird one. So, it turns out that the local "activeContentItem" is getting saved with the new, updated version of the content BEFORE the save function is returning from the API. So if there is an issue, and the save DOESN'T complete for any reason, there will be a discrepancy between what is in the local version and what is in Canvas. A full course rescan fixes it, but that's obviously not the desired behavior. The SECOND issue is that when you choose to delete the Heading in your example above, it really, really should not be throwing that "No changes, so I can't save" exception. I'm going to look into that first and the above issue next. Hope to have a fix today or tomorrow so we can get this PR wrapped up. |
|
@dmols As far as I can tell, the last commit should fix both issues: the php saving function doesn't choke on saving an empty string, and the front end shows the preview properly after the saving is complete. |
dmols
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most recent changes look great, and the rest is working as intended still. Good work!
Each commit is a small, self-contained bug fix:
Addresses failure to save when element is deleted.
Adds specific rule conditions for the AltText form.
Fixes issue where combobox display:block overrode flexbox settings.
Fixes a really stupid issue where undefined !== null and it led to a crash.
Adds additional cleanup for table_structure_misuse errors.
Removes unused devDependency.