Fix broken contract link on static about page

[kosarko]

This pull request improves internal link handling for static pages and updates license-related links in static HTML content. The main changes include refactoring the StaticPageComponent's link processing logic for greater robustness and consistency, and updating static files to use the correct license link.

Improvements to link handling in StaticPageComponent:

• Refactored the processLinks method to robustly resolve anchor elements from events, handle nested elements, and consistently build URLs based on the configured namespace. This ensures all internal, relative, and fragment links are handled correctly, and simplifies the code by removing the unused no_static_ prefix logic.
• Added a helper function in the test suite to simulate link click events, including support for nested elements, and introduced comprehensive tests covering all major link handling scenarios (standard, licenses, relative, fragment, and nested). [1] [2]
• Updated the test environment configuration to use the correct nameSpace property, matching the main application configuration.

Content updates in static HTML files:

• Updated all references to the old no_static_licenses link in both English and Czech static HTML files to the correct licenses link, ensuring users are directed to the right page for license information. [1] [2] [3] [4] [5] [6]

Code cleanup:

• Removed the unused static property no_static_ from StaticPageComponent.

Problem description

1. There's an issue with the /static/about page. The underlying html is @src/static-files/about.html ; when I click the link <a id="distribution-link" href="contract">"Distribution License Agreement"</a> in a browser (links) with disabled js. It works correctly. But in chrome based browsers something interferes. To give a concrete example https://dspace-dev.ufal.mff.cuni.cz/repository/static/about and clicking the link takes me to https://DOMAIN/static/contract (but when I hover over the link I see the correct https://DOMAIN/repository/contract).
2. The no_static_ links don't work without javascript

[kosarko]

@amadulhaxxani seems there's an issue with the "dot relative" links. See the static/about page and Terms of Service link. In js enabled browsers it eventually takes you to the right place (although if you hover over the link it doesn't look like it will). In JS disabled browsers you end up on 404 page. Thoughts?

I'm thinking - should we explicitly add static/ as a part of the relative links?

And similarly for the fragments?

[amadulhaxxani]

I think you’re right to flag it.

I wouldn’t add static/ to everything though.
Maybe:
Use explicit app paths for app pages (like contract, licenses, terms), so they work with and without JS
Keep dot-relative links only for true static-to-static navigation.
For fragments: use #section for same page, and full path + #section for cross Page anchors.
So the fix is mostly about making intent explicit per link type, not globally adding static/

[kosarko]

I think it's the base element in the html head that "confuses" things. Same page #section seems to resolve to baseurl#section. And similar with the "static" links. We should be able to fix the links when no js is involved, by fixing the relative links - providing static/ prefix where we actually mean static pages (omitting it for licenses, contract), providing static and the page name for same page sections?. Now the question is what would this fix do to the version with js, do we still need any special handling then?

[Copilot]

Pull request overview

This PR addresses incorrect navigation from static HTML pages by simplifying how StaticPageComponent intercepts clicks, and updates static HTML content to use the correct license route.

Changes:

• Refactors StaticPageComponent.processLinks to only intercept dot-relative links (./, ../) and correctly resolve the UI namespace.
• Updates StaticPageComponent unit tests (including a helper to simulate nested click targets) and aligns test config to ui.nameSpace.
• Updates static HTML pages to replace no_static_licenses with licenses and adjusts several internal links.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/app/static-page/static-page.component.ts	Simplifies link interception to avoid breaking app-route links like contract under namespaced deployments.
src/app/static-page/static-page.component.spec.ts	Updates config key to nameSpace and adds tests for nested targets + dot-relative link handling.
src/static-files/about.html	Updates license link and rewrites a number of internal links.
src/static-files/cs/about.html	Updates license link and rewrites a number of internal links (Czech).
src/static-files/faq.html	Updates license link and rewrites a number of internal links.
src/static-files/cs/faq.html	Updates license link and rewrites a number of internal links (Czech).
src/static-files/item-lifecycle.html	Updates license link and rewrites a number of internal links.
src/static-files/cs/item-lifecycle.html	Updates license link and rewrites a number of internal links (Czech).

[amadulhaxxani]

@kosarko copilot's comments seem unrelated as I don't experience any reload especially the fragment links. Others are expected to reload as are static pages. If you agree I can just resolve the comments with short replies!

[kosarko]

@amadulhaxxani that's an interesting point it makes - not sure if that's a valid claim though.

But even if that was valid, I guess, an extra page load is better than a broken link. So let's move on with this