Skip to content

Correct the equation of time#253

Open
clark-evans wants to merge 2 commits into
ufs-community:noaa/developfrom
clark-evans:eot-fix
Open

Correct the equation of time#253
clark-evans wants to merge 2 commits into
ufs-community:noaa/developfrom
clark-evans:eot-fix

Conversation

@clark-evans
Copy link
Copy Markdown
Collaborator

This PR implements wrf-model/WRF#2334 for RRTMG shortwave, correcting two parameters in the equation of time that we implemented with #201.

Mandatory Questions

  • Does this PR include any additions or changes to external inputs (e.g., microphysics lookup tables, static data for gravity-wave drag -- things like that)?
    • no
  • Does this PR require updating one or more baselines for the CI tests? If so, what?
    • no

Reviews

  • Is this PR currently draft, still being worked on, or ready for review?
    • ready for review
  • For when this PR begins review, please list the developers/collaborators you'd like to prioritize for review; e.g.,:

Copy link
Copy Markdown
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clark-evans Looks good to me. Thank you for making these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

3 participants