💨 ♻️ Create Vacuum Vessel class

[chris-ashe]

This pull request refactors the calculation and management of vacuum vessel geometry and volumes, moving these responsibilities out of the blanket_library and into a new dedicated VacuumVessel class. The vacuum vessel logic is now encapsulated and run independently, leading to a cleaner separation of concerns and easier maintenance. Related test code and obsolete code paths have also been updated or removed to match the new structure.

Refactoring and Encapsulation of Vacuum Vessel Calculations:

• Introduced a new VacuumVessel class in process/vacuum.py that handles all vacuum vessel geometry and volume calculations, including methods for D-shaped and elliptical vessel geometries, and applies the vessel coverage factor and density calculation. The vacuum vessel logic is now invoked via self.models.vacuum_vessel.run() in the main model runner.

• Removed all vacuum vessel-related calculations from blanket_library.py, including volume and half-height computations, as well as code that previously handled the vacuum vessel as a third component (icomponent==2). The blanket and shield calculations now only consider two components.

Test Code Updates:

• Removed or updated test parameters and assertions in test_blanket_library.py that referenced vacuum vessel geometry or volumes, since these are now handled by the new VacuumVessel class and are no longer part of the blanket library interface.

Other Code Cleanups:

• Commented out obsolete vacuum vessel density calculation logic in hcpb.py, as this is now handled in the new class.

This refactor improves code maintainability by isolating vacuum vessel logic, reducing coupling between the blanket library and vessel calculations, and ensuring that each component is responsible for its own domain.## Description

Checklist

I confirm that I have completed the following checks:

• My changes follow the PROCESS style guide
• I have justified any large differences in the regression tests caused by this pull request in the comments.
• I have added new tests where appropriate for the changes I have made.
• If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
• If I have made documentation changes, I have checked they render correctly.
• I have added documentation for my change, if appropriate.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 56.41026% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.51%. Comparing base (5ea7543) to head (17cecdf).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
process/vacuum.py	63.63%	12 Missing ⚠️
process/blanket_library.py	0.00%	3 Missing ⚠️
process/caller.py	0.00%	1 Missing ⚠️
process/main.py	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4002      +/-   ##
==========================================
+ Coverage   46.49%   46.51%   +0.01%     
==========================================
  Files         123      123              
  Lines       28777    28800      +23     
==========================================
+ Hits        13381    13397      +16     
- Misses      15396    15403       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[j-a-foster]

Happy with transfer of code.

[timothy-nunn]

Before this was inside the if-else statement

PROCESS/process/blanket_library.py

Lines 116 to 133 in ac78fdb

	if divertor_variables.n_divertors == 2:
	htop = hbot
	else:
	# Blanket
	htop = build_variables.z_plasma_xpoint_upper + 0.5 * (
	build_variables.dr_fw_plasma_gap_inboard
	+ build_variables.dr_fw_plasma_gap_outboard
	+ build_variables.dr_fw_inboard
	+ build_variables.dr_fw_outboard
	)
	# Shield
	if icomponent == 1:
	htop = htop + build_variables.dz_blkt_upper
	# Vacuum Vessel
	if icomponent == 2:
	htop = (
	htop + build_variables.dz_blkt_upper + build_variables.dz_shld_upper
	)

[timothy-nunn]

This change is causing ccfe_hcpb_module.vv_density to equal 0 in the unit test. You should mock this now that it has been moved into the vacuum class.

[timothy-nunn]

Although, if this is not being calculated here we need to check the call order to ensure its being calculated before this method is called

[timothy-nunn]

Before this was

PROCESS/process/hcpb.py

Lines 477 to 480 in ac78fdb

	if d_vv_all > 1.0e-6:
	ccfe_hcpb_module.vv_density = fwbs_variables.m_vv / fwbs_variables.vol_vv
	else:
	ccfe_hcpb_module.vv_density = 0.0

Why has the if statement been removed?