-
Notifications
You must be signed in to change notification settings - Fork 17
🎨 Constraint function plots in plot_proc
#4049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…djust font sizes and add new plots in main function
…d normalization and improve axis annotations
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4049 +/- ##
==========================================
+ Coverage 46.49% 47.07% +0.57%
==========================================
Files 123 123
Lines 28777 29779 +1002
==========================================
+ Hits 13381 14019 +638
- Misses 15396 15760 +364 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lace dashed line with arrow annotation, and remove relative change text display
…on to ensure proper string formatting
…function for improved clarity
…ght, add z-order for layering, and improve text annotation with dynamic color and background
|
@chris-ashe could you add an image of the new output here? |
Have added to main PR text now |
jonmaddock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this working, such an improvement to our visualisation! Main points are about calculating stuff that has either been calculated already (I think) or should have been, e.g. normalisation of constraint/bound values.
|
This looks fantastic now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the equality constraint plot is doing anything for me. Its quite hard to meaningfully plot the residuals of these constraints especially given the different orders of magnitude. Would this be better as just a table?
The inequality bar chart should show margin so the bars should come from the right for
|
@chris-ashe when you have actioned all of Jon's comments can you please re-request his review |
jonmaddock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with changes so far, but couple of comments still need resolving.
This pull request enhances the post-optimization reporting for constraint handling in
process/scan.py. The main improvements involve adding more detailed output for both equality and inequality constraints, including physical values, units, symbols, and bounds, which should make debugging and analysis easier.Enhanced constraint reporting:
process_output.ovarre, improving the detail of post-optimization logs.Output formatting improvements:
Checklist
I confirm that I have completed the following checks: