Graceful exit in case of non-existent system #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycedres
force-pushed
the
fix-get-details-non-existen-client
branch
from
81f2876 to
7f7be97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
get_system_detailsto gracefully handle the case where a system does not exist.Also fixes concurrent request failures by updating asyncio.gather usage in
_get_system_detailsto includereturn_exceptions=True. This prevents a "stack trace storm" ofhttpx.ReadErrorsthat occurred when one task failed (e.g., due to a missing system) and cancelled other in-flight requests sharing the samehttpx.AsyncClient.Besides, adds a
--test-idargument toacceptance_tests.pyto allow running individual test cases.